Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added stopwaitsecs value of 300 seconds to supervisord programs #206

Merged

Conversation

JfeedZ
Copy link
Contributor

@JfeedZ JfeedZ commented Feb 27, 2024

In order to stop and resume pruned nodes with supervisord, geth needs more time to gracefully shut down. We can achieve this be setting stopwaitsecs in the supervisord.conf file.

If a value for stopwaitsecs isn't provided, the default value is 10 seconds. After this time has elapsed, supervisord will send a SIGKILL to any remaining child processes. For nodes that have synced a few million blocks, 10 seconds is not enough time for flushing to disk, and geth is stopped with SIGKILL. This results in incomplete/corrupt data, and the node will have to rewind and resync (often from genesis) when resumed. Increasing stopwaitsecs solves this issue by giving the appropriate amount of time for the blockchain to flush to disk before stopping. This will not increase the amount of time it takes to successfully stop a node, as supervisord doesn't wait the full duration once SIGCHLD is received.

@cb-heimdall
Copy link
Collaborator

Review Error for henridevieux @ 2024-02-27 18:13:03 UTC
User must have write permissions to review

@mdehoog mdehoog merged commit debadee into base-org:main Feb 27, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants