Skip to content

Commit

Permalink
Remove dependency on make
Browse files Browse the repository at this point in the history
  • Loading branch information
zencephalon committed Sep 21, 2023
1 parent c1755d7 commit 854c533
Show file tree
Hide file tree
Showing 9 changed files with 10 additions and 42 deletions.
29 changes: 0 additions & 29 deletions Makefile

This file was deleted.

10 changes: 5 additions & 5 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -24,32 +24,32 @@ For example, to start the `web` app locally, you would run `yarn workspace @app/

## Projects

There are three projects which can be run individually, or you can start them all with `make`.
There are three projects which can be run individually.

### Web

```
make web
yarn workspace @app/web dev
```

### Docs

```
make docs
yarn workspace @app/base-docs dev
```

### Bridge

```
make bridge
yarn workspace @app/bridge dev
```

## Contribution

We welcome contributions to Base project! To contribute, please follow these steps:

1. Fork this repository.
2. Make your changes in a new branch.
2. Commit your changes in a new branch.
3. Create a pull request.

### Visual Changes
Expand Down
1 change: 0 additions & 1 deletion apps/base-docs/Dockerfile
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,6 @@ COPY . .

# Install dependencies
RUN yarn --immutable
RUN yarn build

ENV NODE_ENV=production
RUN yarn workspace @app/base-docs build
Expand Down
1 change: 0 additions & 1 deletion apps/bridge/Dockerfile
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,6 @@ ENV BUGSNAG_SESSIONS_URL https://sessions.coinbase.com

# Install dependencies
RUN yarn --immutable
RUN yarn build

RUN yarn workspace @app/bridge next build
RUN yarn workspaces focus --all --production
Expand Down
2 changes: 1 addition & 1 deletion apps/bridge/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -8,5 +8,5 @@ The Base bridge app is a Next.js app.
cd apps/bridge
cp .env.goerli.example .env.local
cd ../..
make bridge
yarn workspace @app/bridge dev
```
1 change: 0 additions & 1 deletion apps/web/Dockerfile
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,6 @@ COPY . .

# Install dependencies
RUN yarn --immutable
RUN yarn build

RUN yarn workspace @app/web next build
RUN yarn workspaces focus --all --production
Expand Down
2 changes: 1 addition & 1 deletion apps/web/README.md
Original file line number Diff line number Diff line change
@@ -1,3 +1,3 @@
# Base Marketing Site

The Base marketing site is a Next.js app. You can run the dev server locally with `make web`.
The Base marketing site is a Next.js app. You can run the dev server locally with `yarn workspace @app/web dev`.
4 changes: 2 additions & 2 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -5,8 +5,8 @@
"repository": "[email protected]::base-org/base-web.git",
"license": "Apache-2.0",
"scripts": {
"build": "make build",
"lint": "make lint"
"build": "yarn workspaces foreach run build",
"lint": "yarn workspaces foreach run lint"
},
"workspaces": [
"apps/*",
Expand Down
2 changes: 1 addition & 1 deletion tools/ci/setup.sh
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ yarn config set enableGlobalCache false
# Immutable is the same as a frozen lockfile
yarn --immutable

# Need to make sure base branch is up-to-date. If not running on a PR, use `BUILDKITE_BRANCH`
# Need to ensure base branch is up-to-date. If not running on a PR, use `BUILDKITE_BRANCH`
BASE_BRANCH=$BUILDKITE_PULL_REQUEST_BASE_BRANCH
if [[ -z "$BASE_BRANCH" ]]; then
BASE_BRANCH=$BUILDKITE_BRANCH
Expand Down

0 comments on commit 854c533

Please sign in to comment.