Remove dependency on make #12
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zencephalon
commented
Sep 21, 2023
| @@ -8,7 +8,6 @@ COPY . . | |||
|
|
|||
| # Install dependencies | |||
| RUN yarn --immutable | |||
| RUN yarn build | |||
There was a problem hiding this comment.
We can just remove all of these because previously yarn build was defined as "" so it didn't actually do anything.
lukasrosario
approved these changes
Sep 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed? Why?
Our build images don't actually have the
makecommand and we don't need it. For simplicity I've replaced our usage of make.Previously
yarn builddid nothing, and all the Dockerfiles called it. I made it soyarn buildactually builds all the projects, which promptly broke all the Dockerfiles due to themakedependency. I've removedyarn buildfrom all the Dockerfiles because it didn't actually do anything.Notes to reviewers
How has it been tested?