Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Brian doyle/add connecting to chain mod #132
Brian doyle/add connecting to chain mod #132
Changes from 4 commits
2e60de2
065cfde
05a048f
eb16417
fbe7381
c4b4611
6b02b55
96966e7
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why not use testnet now for this lesson?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No strong reason, other than it's already imported, and IMO neat to connect to the "real" thing.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A lot of this guide makes mention of the wagmi team's tooling
wagmi
,viem
. Feels like we're specifically promoting them, although the reader may not be familiar with those offerings.I know this is an ongoing debate - but is it possible to reword the content in a way that doesn't feel bias towards specific third party library / tooling, since this guide isn't reliant or specific to those libraries? (other page is wagmi/rainbowkit specific, but this one doesn't seem like it has to be).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think we can with this one. It's going to be wrapped as a single guide for connecting using them, and will eventually also be embedded in the frontend series for Basecamp, which also uses Rainbowkit/Wagmi/Viem. The references are foreshadowing tasks that they'll be doing in the step by step part.
Were it a blog post, we'd definitely need to neutralize it.