Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add landing page for Base Bootcamp #14

Merged
merged 6 commits into from
Oct 4, 2023

Conversation

amhayslipcb
Copy link
Contributor

@amhayslipcb amhayslipcb commented Sep 21, 2023

What changed? Why?
Added base.org/bootcamp landing page.
Added link to Bootcamp under Base Camp nav on docs site.

Screenshot 2023-09-21 at 1 40 23 PM
Screenshot 2023-09-21 at 1 41 16 PM

Notes to reviewers
Has been reviewed by marketing, design, legal and privacy

How has it been tested?
Manually

@amhayslipcb amhayslipcb force-pushed the aaron/base-bootcamp-landing-page branch from eb6991c to 3544e29 Compare September 22, 2023 16:25
@wbnns wbnns marked this pull request as draft September 25, 2023 22:02
@amhayslipcb amhayslipcb changed the title DO NOT MERGE - Add landing page for Base Bootcamp Add landing page for Base Bootcamp Oct 2, 2023
title: 'Build!',
description: (
<div className="text-md font-sans text-white">
<p>Work through <a className="underline" target="_blank" href="https://docs.base.org/base-camp/docs/welcome">Base Camp</a>, meeting regularly with your mentor. You’ll build your final project during the final two weeks - a real-world dapp that you’ll demo virtually on Demo Day.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, this ought to have a linter on it, I'll try to find and configure one. Anytime we use target="blank" for security reasons we also ought to include rel="noreferrer noopener". Could U go through the links in this PR and make sure they all have that?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For sure - thanks!

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks so much, again sorry for the inconvenience, this ought to be a linter autofix in the future

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Weird - it looks like I (something) added it to some of them?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be deleted

@amhayslipcb amhayslipcb marked this pull request as ready for review October 2, 2023 21:20
zencephalon
zencephalon previously approved these changes Oct 2, 2023
Copy link
Collaborator

@zencephalon zencephalon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one question

<meta property="og:title" content="Base" />
<meta
property="og:description"
content="Base is a secure, low-cost, builder-friendly Ethereum L2 built to bring the next billion users onchain."
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we want this to be somewhat more specific to the bootcamp page at all?

@cb-heimdall cb-heimdall dismissed zencephalon’s stale review October 3, 2023 15:28

Approved review 1653543775 from zencephalon is now dismissed due to new commit. Re-request for approval.

@amhayslipcb amhayslipcb marked this pull request as draft October 3, 2023 20:42
@wbnns wbnns added the type: enhancement New feature or request label Oct 4, 2023
@amhayslipcb amhayslipcb force-pushed the aaron/base-bootcamp-landing-page branch from 8008759 to 63f5a17 Compare October 4, 2023 13:54
@amhayslipcb amhayslipcb marked this pull request as ready for review October 4, 2023 14:18
@amhayslipcb amhayslipcb merged commit 81ee08a into master Oct 4, 2023
3 checks passed
@amhayslipcb amhayslipcb deleted the aaron/base-bootcamp-landing-page branch October 4, 2023 16:39
kirkas pushed a commit that referenced this pull request Oct 21, 2024
* Add landing page for Base Bootcamp

* fix lint errors

* add copy changes

* update FAQ copy

* update date and add attr for links

* update meta tags
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants