-
Notifications
You must be signed in to change notification settings - Fork 323
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add landing page for Base Bootcamp #14
Conversation
eb6991c
to
3544e29
Compare
title: 'Build!', | ||
description: ( | ||
<div className="text-md font-sans text-white"> | ||
<p>Work through <a className="underline" target="_blank" href="https://docs.base.org/base-camp/docs/welcome">Base Camp</a>, meeting regularly with your mentor. You’ll build your final project during the final two weeks - a real-world dapp that you’ll demo virtually on Demo Day. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry, this ought to have a linter on it, I'll try to find and configure one. Anytime we use target="blank"
for security reasons we also ought to include rel="noreferrer noopener"
. Could U go through the links in this PR and make sure they all have that?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For sure - thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks so much, again sorry for the inconvenience, this ought to be a linter autofix in the future
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Weird - it looks like I (something) added it to some of them?
package-lock.json
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should be deleted
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just one question
apps/web/pages/bootcamp.tsx
Outdated
<meta property="og:title" content="Base" /> | ||
<meta | ||
property="og:description" | ||
content="Base is a secure, low-cost, builder-friendly Ethereum L2 built to bring the next billion users onchain." |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we want this to be somewhat more specific to the bootcamp page at all?
Approved review 1653543775 from zencephalon is now dismissed due to new commit. Re-request for approval.
8008759
to
63f5a17
Compare
* Add landing page for Base Bootcamp * fix lint errors * add copy changes * update FAQ copy * update date and add attr for links * update meta tags
What changed? Why?
Added base.org/bootcamp landing page.
Added link to Bootcamp under Base Camp nav on docs site.
Notes to reviewers
Has been reviewed by marketing, design, legal and privacy
How has it been tested?
Manually