Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/tailwind lightmode colors #631

Merged
merged 9 commits into from
Jul 12, 2024
Merged

Conversation

brendan-defi
Copy link
Collaborator

What changed? Why?

  • Updated the Tailwind config to have both CDS light and CDS dark colors
  • Updated color references, which were to dark mode refs, to the light mode equivalents

Notes to reviewers

  • dark mode colors are stored within the tailwind colors config under the dark key

How has it been tested?
locally

Copy link

vercel bot commented Jul 11, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
base-web ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 11, 2024 11:03pm
web-base-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 11, 2024 11:03pm

@cb-heimdall
Copy link
Collaborator

Review Error for JFrankfurt @ 2024-07-12 03:50:48 UTC
User failed mfa authentication, see go/mfa-help

@brendan-defi brendan-defi merged commit 55bdf45 into master Jul 12, 2024
9 checks passed
@brendan-defi brendan-defi deleted the fix/tailwind-lightmode-colors branch July 12, 2024 03:54
kirkas pushed a commit that referenced this pull request Oct 21, 2024
* added lightmode colors to tailwind config. Exisitng colors now belong to dark mode

* Changed color ref from gray-10 (dark mode) to gray-90 (light mode) on all pages

* updated color references from yellow-70 (dark mode) to yellow-20 (light mode)

* Added gray-muted to light color scheme

* updated color references from gray-60 (dark mode) to gray-muted (light mode)

* updated color references from gray-60 (dark mode) to gray-muted (light mode)

* test

* test3
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants