Feat: Add walletType to event data #640
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
kirkas
reviewed
Jul 17, 2024
| @@ -32,6 +32,7 @@ export const CustomConnectButton = ({ className }) => { | |||
| action: ActionType.change, | |||
| context: 'navbar', | |||
| address, | |||
| walletType: connector?.name.toLowerCase().replace(/[ \-\/\.]/g, '_'), | |||
There was a problem hiding this comment.
minor: this could be a function so that we don't have the same logic (.toLowerCase().replace(/[ \-\/\.]/g, '_') twice in two files
There was a problem hiding this comment.
good callout. added a helper function in libs for this.
zencephalon
approved these changes
Jul 18, 2024
kirkas
pushed a commit
that referenced
this pull request
Oct 21, 2024
* add walletType to event data * changed walletType property to connector name * removed console logs * add walletType to base-docs wallet_connected event data * sanitized connector name strings * created helper function for string sanitation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed? Why?
eventDataschemawallet_connectedeventNotes to reviewers
How has it been tested?