-
Notifications
You must be signed in to change notification settings - Fork 323
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat: Add walletType to event data #640
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
@@ -32,6 +32,7 @@ export const CustomConnectButton = ({ className }) => { | |||
action: ActionType.change, | |||
context: 'navbar', | |||
address, | |||
walletType: connector?.name.toLowerCase().replace(/[ \-\/\.]/g, '_'), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
minor: this could be a function so that we don't have the same logic (.toLowerCase().replace(/[ \-\/\.]/g, '_')
twice in two files
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
good callout. added a helper function in libs for this.
* add walletType to event data * changed walletType property to connector name * removed console logs * add walletType to base-docs wallet_connected event data * sanitized connector name strings * created helper function for string sanitation
What changed? Why?
eventData
schemawallet_connected
eventNotes to reviewers
How has it been tested?