Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add depositTo and withdrawTo functionality for smart contract wallets #9

Merged
merged 5 commits into from
Sep 25, 2023

Conversation

lukasrosario
Copy link
Collaborator

@lukasrosario lukasrosario commented Sep 20, 2023

What changed? Why?
add depositTo and withdrawTo fields to bridge UI if user is connected with a smart contract wallet

Notes to reviewers

How has it been tested?

@lukasrosario lukasrosario marked this pull request as ready for review September 21, 2023 22:21
Copy link
Collaborator

@zencephalon zencephalon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a few nits

@cb-heimdall
Copy link
Collaborator

Review Error for zencephalon @ 2023-09-22 20:18:04 UTC
User failed mfa authentication, see go/mfa-help

zencephalon
zencephalon previously approved these changes Sep 22, 2023
@cb-heimdall cb-heimdall dismissed zencephalon’s stale review September 25, 2023 19:15

Approved review 1640591100 from zencephalon is now dismissed due to new commit. Re-request for approval.

@lukasrosario lukasrosario merged commit 71b9ec3 into master Sep 25, 2023
3 checks passed
@lukasrosario lukasrosario deleted the lukas/scw-bridging branch September 25, 2023 20:44
amhayslipcb pushed a commit that referenced this pull request Oct 3, 2023
…#9)

* add depositTo and withdrawTo functionality for smart contract wallets

* tx list updates

* compliance check

* fix prettier

* fix prettier & address nits
kirkas pushed a commit that referenced this pull request Oct 21, 2024
…#9)

* add depositTo and withdrawTo functionality for smart contract wallets

* tx list updates

* compliance check

* fix prettier

* fix prettier & address nits
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants