Web 205 cli command analysis download command is not working #99
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Story: https://basepairtech.atlassian.net/browse/WEB-205
Need for the PR
When using the CLI the users are not able to download files/samples that have been shared to them. This is because we are using the directory structure based permission policy when doing
aws cp source destination
.Solution
Instead of relying on the permission set by the policy, we will check the permission using the permission methods defined in https://github.com/basepair/webapp/pull/1588/files#diff-f9795f315b679b5b1e2ced76b2291763cfdf9f48fba6dcd284a20c1e258209d4 to check if the user has access (or has been granted the permission by the owner).
Approach
aws cp
we will be usingrequests
library to dowloaddependent pr:
https://github.com/basepair/webapp/pull/1588