bucket null values getter

basis-company · Mar 26, 2024 · c9ffd0b · c9ffd0b
1 parent c68f983
commit c9ffd0b
Show file tree

Hide file tree

Showing 2 changed files with 21 additions and 3 deletions.
diff --git a/src/KeyValue/Bucket.php b/src/KeyValue/Bucket.php
@@ -6,8 +6,9 @@
 
 use Basis\Nats\Client;
 use Basis\Nats\Consumer\Configuration as ConsumerConfiguration;
-use Basis\Nats\Stream\Stream;
 use Basis\Nats\Message\Payload;
+use Basis\Nats\Stream\Stream;
+use Exception;
 
 class Bucket
 {
@@ -24,8 +25,15 @@ public function __construct(
 
     public function get(string $key)
     {
-        $entry = $this->getEntry($key);
-        return $entry ? $entry->value : null;
+        try {
+            $entry = $this->getEntry($key);
+            return $entry ? $entry->value : null;
+        } catch (Exception $e) {
+            if ($e->getMessage() == 'no message found') {
+                return null;
+            }
+            throw $e;
+        }
     }
 
     public function getConfiguration(): Configuration

diff --git a/tests/Functional/KeyValue/BucketTest.php b/tests/Functional/KeyValue/BucketTest.php
@@ -9,6 +9,16 @@
 
 class BucketTest extends FunctionalTestCase
 {
+    public function testNullValues()
+    {
+        $bucket = $this->createClient()
+            ->getApi()
+            ->getBucket('test_bucket');
+
+        $this->assertSame(0, $bucket->getStatus()->values);
+        $this->assertNull($bucket->get('username'));
+    }
+
     public function testBasics()
     {
         $bucket = $this->createClient()