Rational-quadratic spline transformations #15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CompatHelper: bump compat for DocStringExtensions to 0.9, (keep exist…
|
Thanks! @Micki-D want to start playing with this? @VasylHafych , should be wait for the atomic ops before merging? |
|
Yes, let's merge and review the final version. |
|
Yes, I'm actually already working on the atomic addition.
…________________________________
Von: Vasyl Hafych ***@***.***>
Gesendet: Dienstag, 28. Juni 2022 18:34:28
An: bat/EuclidianNormalizingFlows.jl
Cc: Dudkowiak, Michael; Mention
Betreff: Re: [bat/EuclidianNormalizingFlows.jl] Rational-quadratic spline transformations (PR #15)
Yes, let's merge and review the final version.
—
Reply to this email directly, view it on GitHub<#15 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/AUAIOCXACCLHQ657BHSMMS3VRMSRJANCNFSM52COYKPQ>.
You are receiving this because you were mentioned.Message ID: ***@***.***>
|
Codecov Report
@@ Coverage Diff @@
## main #15 +/- ##
===========================================
- Coverage 66.37% 34.32% -32.05%
===========================================
Files 6 7 +1
Lines 226 437 +211
===========================================
Hits 150 150
- Misses 76 287 +211
Continue to review full report at Codecov.
|
Remove @const macros Fix array indexing in Kernels Fix missing B arg Fix bugs, seperate param and param grad evaluation Fix example notebook
Pull out Array allocation from kernels Separate parameter evaluation and parameter and parameter gradient evaluation
…ix in Kernels Add minor changes
Remove Loops from pb_kernel(), rename utils, represent LogJac as Matr…
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi @oschulz, @Micki-D,
Here is a draft of the Monotonic Rational-quadratic Splines used in the Neural Spline Flows paper. Pullbacks for gradient evaluations are already implemented, but yet without
@atomicoperations. There is a demo notebook that allows playing with toy fits.I will keep this WIP branch here to get your comments. Also, the updates with atomic operations should be pushed here soon.