perf: load existing BUILD files concurrently #1928
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jbedard
force-pushed
the
loadbuild-concurrent
branch
from
a69754a to
66d4849
Compare
jbedard
commented
Sep 18, 2024
| @@ -363,6 +363,9 @@ func resolveFileInfo(wc *walkConfig, dir, rel string, ent fs.DirEntry) fs.DirEnt | |||
| type pathTrie struct { | |||
| children map[string]*pathTrie | |||
| entry *fs.DirEntry | |||
|
|
|||
| buildFileErr error | |||
There was a problem hiding this comment.
This could probably be done different or better, but persisting this error here keeps the scope of this PR minimal. We can think about changing it more in the future.
jbedard
commented
Sep 18, 2024
| @@ -167,7 +167,7 @@ func TestCustomBuildName(t *testing.T) { | |||
| } | |||
| }) | |||
| want := []string{ | |||
| "sub/BUILD.test", | |||
| "sub/BUILD.bazel", | |||
There was a problem hiding this comment.
Why would this happen? 🤔
There was a problem hiding this comment.
Oh, because ValidBuildFileNames can be changed with # gazelle:build_file_name in addition to via the -build_file_name cli arg 😢
Maybe that means this change is not possible?
jbedard
force-pushed
the
loadbuild-concurrent
branch
from
66d4849 to
c5def77
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now that the fs is walked concurrently we can also load BUILDs concurrently at the same time, that is primarily the
rule.LoadFilemethod.If
ReadBuildFilesDiris set then this may have a more significant performance gain because the extraos.ReadDircall will also be run concurrently now.What type of PR is this?
What package or component does this PR mostly affect?
What does this PR do? Why is it needed?
Performance