Skip to content

Commit

Permalink
Remove sha256 from dependencies fetched from codeload.github.com (#824)
Browse files Browse the repository at this point in the history
These archives are prepared on-the-fly by GitHub and are not
guaranteed to be the same every time (for example, the order of files
within the archive could change).

All archives are fetched over https; this should be as secure as
git_repository and still faster.

Related #820
  • Loading branch information
jayconrod authored Sep 12, 2017
1 parent ae70411 commit 2ffc49e
Show file tree
Hide file tree
Showing 2 changed files with 0 additions and 2 deletions.
1 change: 0 additions & 1 deletion go/private/repositories.bzl
Original file line number Diff line number Diff line change
Expand Up @@ -79,7 +79,6 @@ def go_repositories(
# master, as of 14 Aug 2017
url = "https://codeload.github.com/bazelbuild/buildtools/zip/799e530642bac55de7e76728fa0c3161484899f6",
strip_prefix = "buildtools-799e530642bac55de7e76728fa0c3161484899f6",
sha256 = "ea23bbec9e86205b71ef647e1755ae0ec400aa76aeb5d13913d3fc3a37afbb5f",
type = "zip",
)

Expand Down
1 change: 0 additions & 1 deletion proto/go_proto_library.bzl
Original file line number Diff line number Diff line change
Expand Up @@ -333,7 +333,6 @@ def go_proto_repositories(shared = 1):
name = "com_github_google_protobuf",
url = "https://github.com/google/protobuf/archive/v3.4.0.tar.gz",
strip_prefix = "protobuf-3.4.0",
sha256 = "cd55ee08e64a86cf12aaadd4672961813f592c194ed0c9ad94da0ec75acf219f",
)

# Needed for gRPC, only loaded by bazel if used
Expand Down

0 comments on commit 2ffc49e

Please sign in to comment.