Add dependency on cpp toolchain to rules that also depend on cgo_context_data #4128
+19
−10
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
Bug fix
What does this PR do? Why is it needed?
This diff fixes the below issue by adding a cpp toolchain dependency to all the rules that depend on
cgo_context_data
, so they also have their execution platform constrained to the platforms compatible with the selected cpp toolchain.Which issues(s) does this PR fix?
Fixes #4127
Other notes for review
A more ideal fix for this problem would be to turn
cgo_context_data
into a toolchain, however that would be a bigger diff.