Rules pycross fix

[jgautier-dd]

Using toolschains_llvm with rules_pycross results in this error. It is executing the script with a preceeding ../ and adding this case to the existing condition to the cc_wrapper fixes it.

ERROR: /private/var/tmp/_bazel_julian.gautier/f0d3e1ae37dbfe8fdd0ee06626d02ae2/external/rules_pycross~~lock_file~pip/deps/BUILD.bazel:5:8: Building grpclib-0.4.7.tar.gz failed: (Exit 1): wheel_builder failed: error executing WheelBuild command (from target @@rules_pycross~~lock_file~pip//deps:[email protected]) bazel-out/darwin_arm64-opt-exec-ST-502cecfa30dd/bin/external/rules_pycross~/pycross/private/tools/wheel_builder --sdist ... (remaining 27 arguments skipped)

Use --sandbox_debug to see verbose messages from the sandbox and retain the sandbox build root for debugging
/private/var/tmp/_bazel_julian.gautier/f0d3e1ae37dbfe8fdd0ee06626d02ae2/sandbox/darwin-sandbox/737/execroot/_main/bazel-out/darwin_arm64-opt-exec-ST-502cecfa30dd/bin/external/rules_pycross~/pycross/private/tools/wheel_builder.runfiles/_main/../rules_pycross~/pycross/private/tools/wheel_builder.py:394: DeprecationWarning: Python 3.14 will, by default, filter extracted tar archives and reject files or modify their metadata. Use the filter argument to control this behavior.
  f.extractall(sdist_dir)
ERROR: could not find clang; PWD="/private/var/folders/2w/wc8_231n6dng2q_2yplq2cd00000gn/T/wheelbuild0yipqk0q/sdist"; PATH="/bin:/usr/bin:/usr/local/bin".
Traceback (most recent call last):
  File "/private/var/tmp/_bazel_julian.gautier/f0d3e1ae37dbfe8fdd0ee06626d02ae2/sandbox/darwin-sandbox/737/execroot/_main/bazel-out/darwin_arm64-opt-exec-ST-502cecfa30dd/bin/external/rules_pycross~/pycross/private/tools/wheel_builder.runfiles/_main/../rules_pycross~/pycross/private/tools/wheel_builder.py", line 1033, in <module>
    main_wrapper(parse_flags())
  File "/private/var/tmp/_bazel_julian.gautier/f0d3e1ae37dbfe8fdd0ee06626d02ae2/sandbox/darwin-sandbox/737/execroot/_main/bazel-out/darwin_arm64-opt-exec-ST-502cecfa30dd/bin/external/rules_pycross~/pycross/private/tools/wheel_builder.runfiles/_main/../rules_pycross~/pycross/private/tools/wheel_builder.py", line 1026, in main_wrapper
    main(args, _temp_dir, _is_debug)
  File "/private/var/tmp/_bazel_julian.gautier/f0d3e1ae37dbfe8fdd0ee06626d02ae2/sandbox/darwin-sandbox/737/execroot/_main/bazel-out/darwin_arm64-opt-exec-ST-502cecfa30dd/bin/external/rules_pycross~/pycross/private/tools/wheel_builder.runfiles/_main/../rules_pycross~/pycross/private/tools/wheel_builder.py", line 802, in main
    wrapper_sysconfig_vars = generate_cc_wrappers(
                             ^^^^^^^^^^^^^^^^^^^^^
  File "/private/var/tmp/_bazel_julian.gautier/f0d3e1ae37dbfe8fdd0ee06626d02ae2/sandbox/darwin-sandbox/737/execroot/_main/bazel-out/darwin_arm64-opt-exec-ST-502cecfa30dd/bin/external/rules_pycross~/pycross/private/tools/wheel_builder.runfiles/_main/../rules_pycross~/pycross/private/tools/wheel_builder.py", line 319, in generate_cc_wrappers
    wrapped_cc = wrap_cc("cc", orig_cc, cflags, python_exe, bin_dir)
                 ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/private/var/tmp/_bazel_julian.gautier/f0d3e1ae37dbfe8fdd0ee06626d02ae2/sandbox/darwin-sandbox/737/execroot/_main/bazel-out/darwin_arm64-opt-exec-ST-502cecfa30dd/bin/external/rules_pycross~/pycross/private/tools/wheel_builder.runfiles/_main/../rules_pycross~/pycross/private/tools/wheel_builder.py", line 270, in wrap_cc
    version_str = subprocess.check_output([cc_exe, "--version"]).decode("utf-8")
                  ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/private/var/tmp/_bazel_julian.gautier/f0d3e1ae37dbfe8fdd0ee06626d02ae2/execroot/_main/external/rules_python~~python~python_3_12_aarch64-apple-darwin/lib/python3.12/subprocess.py", line 466, in check_output
    return run(*popenargs, stdout=PIPE, timeout=timeout, check=True,
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/private/var/tmp/_bazel_julian.gautier/f0d3e1ae37dbfe8fdd0ee06626d02ae2/execroot/_main/external/rules_python~~python~python_3_12_aarch64-apple-darwin/lib/python3.12/subprocess.py", line 571, in run
    raise CalledProcessError(retcode, process.args,
subprocess.CalledProcessError: Command '['../bazel-execroot/_main/external/toolchains_llvm~~llvm~llvm_toolchain/bin/cc_wrapper.sh', '--version']' returned non-zero exit status 5.
Use --verbose_failures to see the command lines of failed build steps.
ERROR: /private/var/tmp/_bazel_julian.gautier/f0d3e1ae37dbfe8fdd0ee06626d02ae2/external/rules_pycross~~lock_file~pip/deps/BUILD.bazel:5:8 Installing grpclib-0.4.7.whl failed: (Exit 1): wheel_builder failed: error executing WheelBuild command (from target @@rules_pycross~~lock_file~pip//deps:[email protected]) bazel-out/darwin_arm64-opt-exec-ST-502cecfa30dd/bin/external/rules_pycross~/pycross/private/tools/wheel_builder --sdist ... (remaining 27 arguments skipped)

[fmeum]

You can also get a path like this if you include the wrapper in runfiles and invoke it via $(rootpath ... ) or File.short_path. That's probably less likely than your use case, so I'm not against this change at all, but maybe we can find a way to distinguish these two cases.

Could you add a test for this? It would only take an sh_test that adds the toolchain files to data and launches it via $(rootpath ...).