Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update rules_apple(0.32.0) and rules_swift(0.24) #289

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

update rules_apple(0.32.0) and rules_swift(0.24) #289

wants to merge 1 commit into from

Conversation

woshimaliang
Copy link
Contributor

  • rules_apple(0.32.0) and rules_swift(0.24)
  • update bazel to 4.20 in bazelversion. (bazel buildtools is already on 4.0 by f2c1a43)

garrettmoon
garrettmoon approved these changes Dec 9, 2021
View reviewed changes
Copy link
Contributor

@garrettmoon garrettmoon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Should we make sure the breaks in tests / checks are unrelated?

This was referenced Dec 9, 2021
Closed
Merged
@woshimaliang
Copy link
Contributor Author

they seem to be and most of them are resolved by #290, but not entirely fixed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@garrettmoon garrettmoon garrettmoon approved these changes

@jparise jparise Awaiting requested review from jparise

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@woshimaliang @garrettmoon