Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tulsi dSYM and bazel 5.0 #296

Open
wants to merge 7 commits into
base: master
Choose a base branch
from
Open

Tulsi dSYM and bazel 5.0 #296

wants to merge 7 commits into from

Conversation

woshimaliang
Copy link
Contributor

@woshimaliang woshimaliang commented Jan 27, 2022

pick

@zachgrayio
Copy link
Collaborator

zachgrayio commented Jan 28, 2022

PINTEREST_TULSI_COMMIT as it's set in master also includes the dsym change already, probably safe to drop that part of the diff and keep the bazel 5 bits?

@woshimaliang
Copy link
Contributor Author

i thought you said that xchammer version was broken in your m1-sim branch?

Since xchammer is used in both non-M1 and M1 builds, I'd like to do incremental cherry-picks and also verify on non-M1 CIs and M1-device build.

But I can hold off this merge( back to master) for sure.

@zachgrayio
Copy link
Collaborator

i thought you said that xchammer version was broken in your m1-sim branch?

it could just be the release artifact I had to create that's not working, maybe not so much the other small fixes included in the patch. but yeah, its not working either way AFAICT so it's probably OK to revert that altogether and try to cherry-pick smaller pieces and see where that gets us, until someone has more time to dig into getting this fully updated and fix the checks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants