-
Notifications
You must be signed in to change notification settings - Fork 49
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tulsi dSYM and bazel 5.0 #296
base: master
Are you sure you want to change the base?
Conversation
|
i thought you said that xchammer version was broken in your m1-sim branch? Since xchammer is used in both non-M1 and M1 builds, I'd like to do incremental cherry-picks and also verify on non-M1 CIs and M1-device build. But I can hold off this merge( back to master) for sure. |
it could just be the release artifact I had to create that's not working, maybe not so much the other small fixes included in the patch. but yeah, its not working either way AFAICT so it's probably OK to revert that altogether and try to cherry-pick smaller pieces and see where that gets us, until someone has more time to dig into getting this fully updated and fix the checks |
update tulsi to latest to include deprecation of python2 and switch to python3
pull in updated Tulsi to include https://github.com/bazelbuild/tulsi/…
pick