Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes build for Windows #1230

Merged
merged 2 commits into from
Jan 15, 2024
Merged

Fixes build for Windows #1230

merged 2 commits into from
Jan 15, 2024

Conversation

meteorcloudy
Copy link
Member

Fixes #1210

@meteorcloudy meteorcloudy enabled auto-merge (squash) January 15, 2024 16:40
@meteorcloudy meteorcloudy disabled auto-merge January 15, 2024 16:42
@meteorcloudy meteorcloudy marked this pull request as draft January 15, 2024 16:48
@meteorcloudy
Copy link
Member Author

Not as simple as I thought..

@meteorcloudy
Fixes buildtools on Windows
07ff080 
- Removed C++ options in .bazelrc since we by default using Bazel 7
  which defauts to c++17
- Shorten the workspace name to avoid long path issue on Windows.

Fixes #1210
@meteorcloudy meteorcloudy changed the title Fixes c++14 flags for Windows Fixes build for Windows Jan 15, 2024
@meteorcloudy
Copy link
Member Author

Turns out it's a long path issue on Windows.

@meteorcloudy meteorcloudy marked this pull request as ready for review January 15, 2024 17:07
@meteorcloudy meteorcloudy requested a review from vladmos January 15, 2024 17:07
@meteorcloudy meteorcloudy enabled auto-merge (squash) January 15, 2024 17:13
@meteorcloudy
Copy link
Member Author

After this one, we still need to update rules_go to fix downstream breakage: https://buildkite.com/bazel/bazel-at-head-plus-downstream/builds/3592#018d0add-494c-4c59-b452-da6cd582688c

vladmos
vladmos approved these changes Jan 15, 2024
View reviewed changes
Copy link
Member

@vladmos vladmos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@meteorcloudy meteorcloudy merged commit 633cf94 into master Jan 15, 2024
5 checks passed
@meteorcloudy
Copy link
Member Author

@vladmos Can you please try to update rules_go to fix the breakage with Bazel@HEAD?

(04:01:30) ERROR: Traceback (most recent call last):
	File "/var/lib/buildkite-agent/.cache/bazel/_bazel_buildkite-agent/9e21fb089b9da2ba3a2c9233fa8beaa3/external/io_bazel_rules_go/go/private/rules/transition.bzl", line 126, column 47, in _go_transition_impl
		platform = platform_from_crosstool(crosstool_top, cpu)
	File "/var/lib/buildkite-agent/.cache/bazel/_bazel_buildkite-agent/9e21fb089b9da2ba3a2c9233fa8beaa3/external/io_bazel_rules_go/go/platform/crosstool.bzl", line 57, column 27, in platform_from_crosstool
		platform = matcher(crosstool_top, cpu)
	File "/var/lib/buildkite-agent/.cache/bazel/_bazel_buildkite-agent/9e21fb089b9da2ba3a2c9233fa8beaa3/external/io_bazel_rules_go/go/platform/crosstool.bzl", line 38, column 21, in _match_android
		crosstool_top.workspace_name == "androidndk":
Error: 'NoneType' value has no field or method 'workspace_name'

@vladmos
Copy link
Member

vladmos commented Jan 23, 2024

@meteorcloudy Updated in #1234

apattidb pushed a commit to databricks/buildtools that referenced this pull request May 10, 2024
@meteorcloudy @apattidb
Fixes build for Windows (bazelbuild#1230)
e402d7b 
* Fixes buildtools on Windows

- Removed C++ options in .bazelrc since we by default using Bazel 7
  which defauts to c++17
- Shorten the workspace name to avoid long path issue on Windows.

Fixes bazelbuild#1210

* Fix test
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vladmos vladmos vladmos approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

fatal error C1083: Cannot open include file: 'google/protobuf/compiler/objectivec/text_format_decode_data.h':
3 participants
@meteorcloudy @vladmos @23cult