Python code-gen; rename query methods (#6887)

The class `TargetTagFilter` is about filtering targets by tag and is agnostic about its use for the code-gen filtering. This commit renames the methods to make this more obvious.
bazelbuild · Oct 18, 2024 · d8928b9 · d8928b9
1 parent c1a3c5a
commit d8928b9
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 5 deletions.
diff --git a/base/src/com/google/idea/blaze/base/dependencies/BlazeQueryTargetTagFilter.java b/base/src/com/google/idea/blaze/base/dependencies/BlazeQueryTargetTagFilter.java
@@ -64,7 +64,7 @@ public class BlazeQueryTargetTagFilter implements TargetTagFilter {
 
   @Nullable
   @Override
-  public List<TargetExpression> doFilterCodeGen(
+  public List<TargetExpression> doFilter(
       Project project,
       BlazeContext context,
       List<TargetExpression> targets,

diff --git a/base/src/com/google/idea/blaze/base/dependencies/TargetTagFilter.java b/base/src/com/google/idea/blaze/base/dependencies/TargetTagFilter.java
@@ -49,13 +49,13 @@ static boolean hasProvider() {
    * @param targets is a list of Bazel targets to filter.
    * @return a subset of the supplied targets that include one of the supplied {code tags}.
    */
-  static List<TargetExpression> filterCodeGen(
+  static List<TargetExpression> filter(
       Project project,
       BlazeContext context,
       List<TargetExpression> targets,
       Set<String> tags) {
     return Arrays.stream(EP_NAME.getExtensions())
-        .map(p -> p.doFilterCodeGen(project, context, targets, tags))
+        .map(p -> p.doFilter(project, context, targets, tags))
         .filter(Objects::nonNull)
         .findFirst()
         .orElse(ImmutableList.of());
@@ -65,7 +65,7 @@ static List<TargetExpression> filterCodeGen(
    * {@see #filterCodeGen}
    */
   @Nullable
-  List<TargetExpression> doFilterCodeGen(
+  List<TargetExpression> doFilter(
       Project project,
       BlazeContext context,
       List<TargetExpression> targets,

diff --git a/base/src/com/google/idea/blaze/base/sync/SyncProjectTargetsHelper.java b/base/src/com/google/idea/blaze/base/sync/SyncProjectTargetsHelper.java
@@ -199,7 +199,7 @@ private static ImmutableList<TargetExpression> deriveTargetsFromDirectories(
           .collect(Collectors.toSet());
 
       if (!activeLanguageCodeGeneratorTags.isEmpty() && projectViewSet.getScalarValue(EnablePythonCodegenSupport.KEY).orElse(false)) {
-        retainedByCodeGen = TargetTagFilter.filterCodeGen(
+        retainedByCodeGen = TargetTagFilter.filter(
             project,
             context,
             rejectedByKind,