Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Use "" alias for for the root module back #6851

Merged
merged 1 commit into from
Oct 7, 2024

Conversation

tpasternak
Copy link
Collaborator

@tpasternak tpasternak commented Oct 4, 2024

It is still not documented well, but "" caused crashes on Windows

closes #6850

Checklist

  • I have filed an issue about this change and discussed potential changes with the maintainers.
  • I have received the approval from the maintainers to make this change.
  • This is not a stylistic, refactoring, or cleanup change.

Please note that the maintainers will not be reviewing this change until all checkboxes are ticked. See
the Contributions section in the README for more
details.

Discussion thread for this change

Issue number: <please reference the issue number or url here>

Description of this change

It is still not documented well, but "<root>" caused crashes on Windows

closes bazelbuild#6850
@tpasternak tpasternak marked this pull request as ready for review October 4, 2024 21:22
@github-actions github-actions bot added product: CLion CLion plugin product: IntelliJ IntelliJ plugin product: GoLand GoLand plugin awaiting-review Awaiting review from Bazel team on PRs labels Oct 4, 2024
@tpasternak tpasternak changed the title Revert "fix: Fix bazel mod deps execution (#6826)" fix: Use "" alias for for the root module back Oct 4, 2024
@tpasternak tpasternak merged commit 2322829 into bazelbuild:master Oct 7, 2024
8 checks passed
@tpasternak tpasternak deleted the fix-tests branch October 7, 2024 08:27
@github-actions github-actions bot removed the awaiting-review Awaiting review from Bazel team on PRs label Oct 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
product: CLion CLion plugin product: GoLand GoLand plugin product: IntelliJ IntelliJ plugin
Projects
Development

Successfully merging this pull request may close these issues.

Windows tests are red
4 participants