Make toolchain registration optional #50
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The moment you add the current
rules_android_ndk
to a workspace, the build breaks ifANDROID_NDK_HOME
is not set, becausenative.register_toolchains
is always called implicitly.One solution is to allow users to opt-in into setting up the repository only (which is what you'd do with
bzlmod
) and either callregister_toolchains
themselves, or use--extra_toolchains=@androidndk//:all
.Downside: this breaks the current API and we can either use a different approach, or mention it in some release notes