Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make toolchain registration optional #50

Closed
wants to merge 2 commits into from

Conversation

gferon
Copy link
Contributor

@gferon gferon commented Sep 19, 2023

The moment you add the current rules_android_ndk to a workspace, the build breaks if ANDROID_NDK_HOME is not set, because native.register_toolchains is always called implicitly.

One solution is to allow users to opt-in into setting up the repository only (which is what you'd do with bzlmod) and either call register_toolchains themselves, or use --extra_toolchains=@androidndk//:all.

Downside: this breaks the current API and we can either use a different approach, or mention it in some release notes

@google-cla
Copy link

google-cla bot commented Sep 19, 2023

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@gferon gferon force-pushed the register-ndk-toolchains-func branch from 17ab859 to 11dadbe Compare September 19, 2023 09:19
@gferon
Copy link
Contributor Author

gferon commented Sep 20, 2023

Superseded by #51

@gferon gferon closed this Sep 20, 2023
@gferon gferon deleted the register-ndk-toolchains-func branch September 20, 2023 08:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant