find_cc_toolchain: Don't fail on missing toolchain if mandatory = False
#298
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…False` `find_cc_toolchain` is sometimes used by helper functions that may not have knowledge of the rule calling them. Making the function not fail if the calling rule did not use `use_cc_toolchain()` allows callers to avoid checking if `CC_TOOLCHAIN_TYPE` is in `ctx.toolchains` before calling `find_cc_toolchain`.
Yannic
requested review from
trybka,
armandomontanez,
pzembrod,
comius and
c-mita
as code owners
|
The test failure looks unrelated |
|
friendly ping? |
|
cc @katre I don't think |
|
I agree: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
find_cc_toolchainis sometimes used by helper functions that may not have knowledge of the rule calling them. Making the function not fail if the calling rule did not useuse_cc_toolchain()allows callers to avoid checking ifCC_TOOLCHAIN_TYPEis inctx.toolchainsbefore callingfind_cc_toolchain.