Feature/additional link outputs #320
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The script expected a param file as input which is not actually what it gets. Fixed to parse the full command line arguments.
add a `cc_binary` example to test the toolchain in another scenario.
yuvalmo
requested review from
trybka,
armandomontanez,
pzembrod,
comius and
c-mita
as code owners
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #24990.
Tests the
additional_link_outputsfeature implemented in this pull request.For this to work, the pull request needs to be merged. I tested it with a dev version for now.
I also had to fix some things in the
custom_toolchainwhich were not up-to-date, in order to run the use-cases and test the feature. I separated it into different commits for better readability.