Add partial support for external_include_paths #323
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
external_include_paths is an interesting feature + variable, that when enabled, puts include paths into a separate external_include_paths variable (separate as in not included in the default includes features). It's also notably not in the legacy features java code. With this change it is never activated unless users manually create the feature and add it to their know features.
keith
requested review from
trybka,
armandomontanez,
pzembrod,
comius and
c-mita
as code owners
|
I would love a tip for how to fix the need for users to put this in their know features, I think I'm missing some API for this case |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
external_include_paths is an interesting feature + variable, that when
enabled, puts include paths into a separate external_include_paths
variable (separate as in not included in the default includes features).
It's also notably not in the legacy features java code. With this change
it is never activated unless users manually create the feature and add
it to their know features.