Skip to content

Commit

Permalink
Remove dependency to archived closure-library. (#641)
Browse files Browse the repository at this point in the history 
* .

* Add base.js

* add comment

---------

Co-authored-by: mollyibot <[email protected]>
  • Loading branch information
@gkdn @mollyibot
gkdn and mollyibot authored Jan 10, 2025
1 parent fc64784 commit 07c7928
Show file tree
Hide file tree
Showing 4 changed files with 3,554 additions and 17 deletions.
2 changes: 1 addition & 1 deletion closure/compiler/closure_base_js_library.bzl
View file
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ def _closure_base_js_library(ctx):
if not ctx.files.srcs:
fail("Must provide sources")

return create_closure_js_library(ctx, ctx.files.srcs)
return create_closure_js_library(ctx, ctx.files.srcs, lenient=True)

# Only usable to create a closure js library for base.js
closure_base_js_library = rule(
Expand Down
7 changes: 3 additions & 4 deletions closure/private/BUILD
View file
Original file line number Diff line number Diff line change
Expand Up @@ -12,8 +12,8 @@
# See the License for the specific language governing permissions and
# limitations under the License.

load("//closure/compiler:closure_base_js_library.bzl", "closure_base_js_library")
load("@bazel_skylib//:bzl_library.bzl", "bzl_library")
load("//closure/compiler:closure_base_js_library.bzl", "closure_base_js_library")

package(default_visibility = ["//visibility:public"])

Expand All @@ -28,9 +28,8 @@ sh_binary(

closure_base_js_library(
name = "base_lib",
srcs = [
"@com_google_javascript_closure_library//closure/goog:base.js",
],
# TODO(goktug): replace with base.js from compiler when included in the artifact.
srcs = ["base.js"],
)

bzl_library(
Expand Down
Loading

4 comments on commit 07c7928

@mollyibot
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we remove this dependency entirely, I happen to find some references in j2cl_proto for example https://github.com/google/j2cl-protobuf/blob/b5ea3cf5dc7b682d7a797119a9c8949d84ca5938/third_party/BUILD#L103

@gkdn
Copy link
Collaborator Author

@gkdn gkdn commented on 07c7928 Jan 15, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

proto CI's are disabled both internally and externally. Have you hit any problems other than seeing them?

@mollyibot
Copy link
Collaborator

@mollyibot mollyibot commented on 07c7928 Jan 15, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I hit problems with jre tests in j2cl repo, and I happen to find these references in j2cl_proto but not hit build/runtime problems when checking where javascript_closure_library is used.

@gkdn
Copy link
Collaborator Author

@gkdn gkdn commented on 07c7928 Jan 15, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As I mentioned earlier, I am removing references from the j2cl repo so that should be fine.

Please sign in to comment.