Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for print_progress to container_pull #535

Closed
wants to merge 2 commits into from

Conversation

scele
Copy link
Contributor

@scele scele commented Oct 4, 2018

Add minimal prints to indicate puller progress if container_pull
has print_progress=True attribute. The intention is that the pull
operation would provide some feedback to the user, instead of bazel
getting seemingly stuck for 10 minutes when pulling an image that is
many gigabytes in size.

Pending pull request to upstream puller.par is here:
google/containerregistry#66

Add minimal prints to indicate puller progress if container_pull
has print_progress=True attribute.  The intention is that the pull
operation would provide some feedback to the user, instead of bazel
getting seemingly stuck for 10 minutes when pulling an image that is
many gigabytes in size.

Pending pull request to upstream puller.par is here:
google/containerregistry#66
@scele
Copy link
Contributor Author

scele commented Oct 4, 2018

@nlopezgi any thoughts on this? We've had problems with developers reporting "bazel is stuck", and turns out it was just pulling a big image for 10 minutes. There are other ways to expose this, for example adding quiet=True|False and puller_args=[string] flags. Or ideally workspace rules could support mnemonic, like actions, but that would need to go into bazel core..

If you agree something like this is a good idea, perhaps you could vouch for the related puller.par change that hasn't gotten much attention here: google/containerregistry#66

@ittaiz
Copy link
Member

ittaiz commented Oct 31, 2018

+100 this is a big problem for us as well

@ittaiz
Copy link
Member

ittaiz commented Nov 12, 2018

Is it worth while adding the attribute and quiet=false for now? It will bring better info for failure cases I think

@nlopezgi
Copy link
Contributor

nlopezgi commented Jul 3, 2019

is this PR still relevant now that we're moving to go containerregistry? let me know if so, otherwise i'll close.

@scele
Copy link
Contributor Author

scele commented Jul 4, 2019

Not in its current form at least. Closing.

@scele scele closed this Jul 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants