Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(pypi): only query SimpleAPI for pkgs that have shas #2527

Merged
merged 2 commits into from
Dec 27, 2024
Merged

feat(pypi): only query SimpleAPI for pkgs that have shas #2527

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7a63133
feat(pypi): only query SimpleAPI for pkgs that have shas
aignas Dec 24, 2024
6085eb5
Merge branch 'main' into fix/only-call-simple-api-for-distros-with-ha…
aignas Dec 25, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,6 +56,8 @@ Unreleased changes template.
* Bazel 6 support is dropped and Bazel 7.4.1 is the minimum supported
version, per our Bazel support matrix. Earlier versions are not
tested by CI, so functionality cannot be guaranteed.
* ({bzl:obj}`pip.parse`) Only query SimpleAPI for packages that have
sha values in the `requirements.txt` file.

{#v0-0-0-fixed}
### Fixed
Expand Down
1 change: 1 addition & 0 deletions python/private/pypi/parse_requirements.bzl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -184,6 +184,7 @@ def parse_requirements(
req.distribution: None
for reqs in requirements_by_platform.values()
for req in reqs.values()
if req.srcs.shas
}),
)

Expand Down
2 changes: 1 addition & 1 deletion tests/pypi/extension/extension_tests.bzl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -575,7 +575,7 @@ some_pkg==0.0.1
index_url = "pypi.org",
index_url_overrides = {},
netrc = None,
sources = ["simple", "some_pkg"],
sources = ["simple"],
),
"cache": {},
"parallel_download": False,
Expand Down