fix: Avoid creating URLs with empty path segments from index URLs in environment variables #2557
+143
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WillMorrison
requested review from
rickeylev,
aignas and
groodt
as code owners
WillMorrison
force-pushed
the
env_var_urls
branch
from
98d7003 to
bd71ffc
Compare
aignas
reviewed
Jan 14, 2025
| download = download, | ||
| read = lambda i: "contents of " + i, | ||
| path = lambda i: "path/for/" + i, | ||
| get_auth = lambda ctx, urls, ctx_attr: struct(), |
There was a problem hiding this comment.
I think adding an extra arg to simpleapi_download would be better. ctx in general does not have get_auth attribute.
| @@ -57,6 +57,7 @@ Unreleased changes template. | |||
| {#v0-0-0-fixed} | |||
| ### Fixed | |||
| * (gazelle) Providing multiple input requirements files to `gazelle_python_manifest` now works correctly. | |||
| * (bazel downloader) Handle trailing slashes in pip index URLs in environment variables | |||
There was a problem hiding this comment.
Suggested change
| * (bazel downloader) Handle trailing slashes in pip index URLs in environment variables | |
| * (pypi) Handle trailing slashes in pip index URLs in environment variables, | |
| fixes [#2554](https://github.com/bazelbuild/rules_python/issues/2554). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change updates
_read_simpleapisuch that it correctly handles the case where the index URL is specified in an environment variable and contains a trailing slash. The URL construction would have introduced an empty path segment, which is now removed.Fixes: #2554