Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(pypi): include pyi files in data attribute #2558

Merged
merged 1 commit into from
Jan 13, 2025

Conversation

rickeylev
Copy link
Collaborator

Restore the previous behavior of pyi files being included in data. This is because
certain packages (librosa, at least) expect the pyi files to be available at runtime.

Copy link
Collaborator

@aignas aignas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SGTM for reverting. Should we include them in both places though?

@rickeylev rickeylev added this pull request to the merge queue Jan 13, 2025
Merged via the queue into bazelbuild:main with commit 1aa0d9f Jan 13, 2025
4 checks passed
@rickeylev rickeylev deleted the fix.include.pyi.in.pypi.data branch January 13, 2025 02:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants