Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test Chartbeat on Lite pages #11579

Draft
wants to merge 19 commits into
base: latest
Choose a base branch
from
Draft

Conversation

amoore108
Copy link
Contributor

@amoore108 amoore108 commented Apr 30, 2024

Overall changes

  • Initial implementation of adding Chartbeat on Lite pages, mainly to test that this approach works and sends data to Chartbeat.

Code changes

  • Adds checks for Lite mode and Chartbeat toggle, returning the Canonical Chartbeat component if true
  • Adds tests to check that the correct Helmet script tags are added to the page for Lite mode

Testing

  1. Visit http://localhost:7080/pidgin/articles/cj5l1958ljjo.lite?renderer_env=live
  2. Open the Network tab (may need to refresh the page to see all the transferred files)
  3. Confirm that chartbeat.js is downloaded
  4. Stay the page for awhile and observe 'ping' requests to Chartbeat
  5. Click on one of the 'ping' requests and check that values are present

Helpful Links

Add Links to useful resources related to this PR if applicable.

Coding Standards

Repository use guidelines

@amoore108 amoore108 self-assigned this Apr 30, 2024
@amoore108 amoore108 changed the title Add Chartbeat to Lite pages Test Chartbeat on Lite pages May 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant