-
Notifications
You must be signed in to change notification settings - Fork 224
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Render the script switch button on the header container on storybook #11984
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks for doing this! somewhat relatedly, just wondering if we should delete the storybook for the Brand container as this can be seen in situ in the header? maybe a little overkill , does no harm to leave it 😊
Guess no harm in leaving it for now. It would be good to go and clean up the stories & remove dupes, but not today 😅 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🎯
…torybook-script-link
…torybook-script-link
…s only) from the sidebar
…torybook-script-link
Resolves JIRA N/A
Overall changes
Ensures the script link component is visible on the header for variant services
Code changes
Allow script link to appear on the Header container for all variant services
Testing
Serbian
https://storybook-script-link--5d28eb3fe163f6002046d6fa.chromatic.com/?path=/story/containers-header--header&globals=service.service:serbian;service.variant:cyr
https://storybook-script-link--5d28eb3fe163f6002046d6fa.chromatic.com/?path=/story/containers-header--header&globals=service.service:serbian;service.variant:lat
UKChina
https://storybook-script-link--5d28eb3fe163f6002046d6fa.chromatic.com/?path=/story/containers-header--header&globals=service.service:ukchina;service.variant:simp
https://storybook-script-link--5d28eb3fe163f6002046d6fa.chromatic.com/?path=/story/containers-header--header&globals=service.service:ukchina;service.variant:trad
Zhongwen
https://storybook-script-link--5d28eb3fe163f6002046d6fa.chromatic.com/?path=/story/containers-header--header&globals=service.service:zhongwen;service.variant:simp
https://storybook-script-link--5d28eb3fe163f6002046d6fa.chromatic.com/?path=/story/containers-header--header&globals=service.service:zhongwen;service.variant:trad
Helpful Links
Add Links to useful resources related to this PR if applicable.
Coding Standards
Repository use guidelines