Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Render the script switch button on the header container on storybook #11984

Merged
merged 39 commits into from
Oct 31, 2024

Conversation

@karinathomasbbc karinathomasbbc self-assigned this Sep 17, 2024
@karinathomasbbc karinathomasbbc changed the title Storybook script link Render the script switch button on the header container on storybook Sep 17, 2024
@karinathomasbbc karinathomasbbc marked this pull request as ready for review September 17, 2024 17:26
Copy link
Contributor

@emilysaffron emilysaffron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for doing this! somewhat relatedly, just wondering if we should delete the storybook for the Brand container as this can be seen in situ in the header? maybe a little overkill , does no harm to leave it 😊

@karinathomasbbc
Copy link
Contributor Author

thanks for doing this! somewhat relatedly, just wondering if we should delete the storybook for the Brand container as this can be seen in situ in the header? maybe a little overkill , does no harm to leave it 😊

Guess no harm in leaving it for now. It would be good to go and clean up the stories & remove dupes, but not today 😅

Copy link
Contributor

@eagerterrier eagerterrier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎯

@karinathomasbbc karinathomasbbc merged commit afc1621 into latest Oct 31, 2024
12 checks passed
@karinathomasbbc karinathomasbbc deleted the storybook-script-link branch October 31, 2024 15:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants