Update padding for embed wrapper #12106
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amoore108
reviewed
Oct 28, 2024
| @@ -25,7 +25,7 @@ const getWrapperHeightStyles = oEmbed => { | |||
| }; | |||
|
|
|||
| const Wrapper = styled.div` | |||
| margin-bottom: ${GEL_SPACING_TRPL}; | |||
| margin: ${GEL_SPACING} 0; | |||
There was a problem hiding this comment.
This will affect embeds in Articles as well. Is that required/expected by UX?
There was a problem hiding this comment.
yeah lol just realised that too ! Talking through it with UX now - can ignore this PR for now 🤦
There was a problem hiding this comment.
No probs! Just wanted to check 😄
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overall changes
Updates top and bottom padding for embed wrapper to be 8px as requested by UX
Code changes
Testing
Helpful Links
Add Links to useful resources related to this PR if applicable.
Coding Standards
Repository use guidelines