-
Notifications
You must be signed in to change notification settings - Fork 224
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WSTEAM1-1413: Article Election Banner Experiment #12128
Merged
HarveyPeachey
merged 15 commits into
latest
from
WSTEAM1-1413-election-banner-experiment
Nov 4, 2024
+57
−8
Merged
Changes from all commits
Commits
Show all changes
15 commits
Select commit
Hold shift + click to select a range
74f4902
adds basic code for minimal election banner experiment
HarveyPeachey 331dc67
Merge branch 'latest' of https://github.com/bbc/simorgh into WSTEAM1-…
HarveyPeachey 0b97af2
adds election toggle to mvt experiment code
HarveyPeachey bd3d623
moves variation check
HarveyPeachey 3fdb261
temp remove election banner toggle
HarveyPeachey 06f9d05
re-adds election banner
HarveyPeachey e9ee399
removes mundo check as wont be using recs metric
HarveyPeachey e5dfba6
updates election banner id
HarveyPeachey a4ba107
adds custom experiment variant ati value
HarveyPeachey 937eaab
changes enabled experiment in list
HarveyPeachey 8e62c26
only return experimentVariant if exists
HarveyPeachey e345699
linting fix
HarveyPeachey e095635
changes to mvt items
HarveyPeachey d52af2d
fixes unit test
HarveyPeachey 57b0f2d
Merge branch 'latest' into WSTEAM1-1413-election-banner-experiment
HarveyPeachey File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,4 +1,7 @@ | ||
import withOptimizelyProvider from '#app/legacy/containers/PageHandlers/withOptimizelyProvider'; | ||
import ArticlePage from './ArticlePage'; | ||
import applyBasicPageHandlers from '../utils/applyBasicPageHandlers'; | ||
|
||
export default applyBasicPageHandlers(ArticlePage); | ||
const OptimizelyArticle = withOptimizelyProvider(ArticlePage); | ||
|
||
export default applyBasicPageHandlers(OptimizelyArticle); |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Needs to be addressed for upcoming experiments