Add Apache-2.0 license #89
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -8,7 +8,8 @@ | |||
| "test": "jest" | |||
| }, | |||
| "author": "BBC News and Weather Apps", | |||
| "license": "ISC", | |||
| "private": true, | |||
There was a problem hiding this comment.
Don't think we need this line?
There was a problem hiding this comment.
This there to stop people accidentally publishing the project to NPM (because that's not really something we want to do with this project — it's not intended to be installed via a registry, it's intended to be checked-out from GitHub).
|
This all makes sense to me. |
TimPerry
approved these changes
Mar 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
LICENSEfile with the Apache 2.0 license (the license we usually use at the BBC for open source projects).npmpackage.jsonfilesnpmpackages to beprivateto avoid them being accidentally published to the NPM registry (these projects are not really for distribution like that)Why?