Handle phone numbers that start with "%2B" #610
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
crummy
changed the title
bbernhard
reviewed
Oct 31, 2024
| number, err := url.PathUnescape(c.Param("number")) | ||
| if err != nil { | ||
| c.JSON(400, Error{Msg: "Couldn't process request - malformed number"}) | ||
| } |
There was a problem hiding this comment.
Thanks for the PR!
In general it looks good, the only thing that is missing is a return in case a malformed number is provided.
|
Thanks a lot! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
I've generated a Java SDK for the signal-cli-rest-api with liblab. They parse their URL arguments with
URLEncoder.encode(value, StandardCharsets.UTF_8.toString());, which turns+1234into%2B1234. Thus, when I use the client to query the API, I get a 400 error because/v1/groups/%2B1234is malformed.Solution
Escape the number when parsing it.
Comments
I have never written Go code before, so feel free to point out any problems here!
Googling, it seems like
+is actually allowed in part of the URL - it must be escaped if following a?, and can be escaped before. So it seems reasonable to handle both ways.