Add a framework for including predefined specifications. #14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm not sure if something like this is desired in pylabels, but since I needed to build a library of predefined specifications for my own use, I thought I would see if you'd like to include it directly.
The idea is to house a number of predefined specifications for known label types. In this PR, I've included a specification for Avery 22822. I focused on making the definition super simple, with a built-in conversion for portrait vs landscape orientation.
I included some unit tests for this new approach as well as a convenience method for listing known specifications (run
python -m labels.predefined)Let me know what you think. I'm happy to make additional changes, but thought this would be a good spot to start the conversation.