Merge pull request #154 from bcgov/oleksandrbohuslavskyi

DSS-305 - Remove LG id from the Delisting Request form. DSS-301 - http/https wording
bcgov · Apr 16, 2024 · df10bbe · df10bbe
2 parents 22d778f + df0b5a6
commit df10bbe
Show file tree

Hide file tree

Showing 4 changed files with 6 additions and 22 deletions.
diff --git a/frontend/src/app/common/models/delisting-request.ts b/frontend/src/app/common/models/delisting-request.ts
@@ -1,5 +1,4 @@
 export interface DelistingRequest {
-    lgId: number;
     platformId: number;
     listingId: string;
     listingUrl: string;

diff --git a/frontend/src/app/features/components/compliance-notice/compliance-notice.component.html b/frontend/src/app/features/components/compliance-notice/compliance-notice.component.html
@@ -51,13 +51,13 @@
     <div class="form-group-row">
         <div class="form-group-row-col">
             <span class="info-tooltip"
-                pTooltip="Copy and paste the external URL of the STR listing from the platform website."
+                pTooltip="Copy and paste the external URL of the STR listing from the platform listing. URL must begin with “https://”."
                 tooltipPosition="top" placeholder="Top"></span>
             <label for="listingUrl">Add the URL of the short-term rental listing</label>
         </div>
         <div class="form-group-row-col">
-            <input class="long-text-field" type="text" placeholder="Enter URL" pInputText formControlName="listingUrl"
-                id="listingUrl" name="listingUrl" required />
+            <input class="long-text-field" type="text" placeholder="Enter URL beginning with http…" pInputText
+                formControlName="listingUrl" id="listingUrl" name="listingUrl" required />
         </div>
         <div class="form-group-row-col validation-errors"
             *ngIf="!listingUrlControl.pristine && listingUrlControl.errors">

diff --git a/frontend/src/app/features/components/delisting-request/delisting-request.component.html b/frontend/src/app/features/components/delisting-request/delisting-request.component.html
@@ -10,20 +10,6 @@
 </div>
 
 <form *ngIf="!hideForm" [formGroup]="myForm" (ngSubmit)="onPreview()">
-    <div class="form-group-row">
-        <div class="form-group-row-col">
-            <label for="lgId">Request Initiated by</label>
-        </div>
-        <div class="form-group-row-col">
-            <p-dropdown [options]="initiatorsOptions" formControlName="lgId" placeholder="Select local government"
-                id="lgId" name="lgId" [required]="true"></p-dropdown>
-        </div>
-        <div class="form-group-row-col validation-errors" *ngIf="!lgIdControl.pristine && lgIdControl.errors">
-            <small id="requiredLgIdControl" *ngIf="lgIdControl.errors?.['required']">Request initiator is
-                required</small>
-        </div>
-    </div>
-
     <div class="form-group-row">
         <div class="form-group-row-col">
             <label for="platformId">Select a Platform Representative for</label>
@@ -42,13 +28,13 @@
     <div class="form-group-row">
         <div class="form-group-row-col">
             <span class="info-tooltip"
-                pTooltip="Copy and paste the external URL of the STR listing from the platform website."
+                pTooltip="Copy and paste the external URL of the STR listing from the platform listing. URL must begin with “https://”."
                 tooltipPosition="top" placeholder="Top"></span>
             <label for="listingUrl">Add URL of the short-term rental listing</label>
         </div>
         <div class="form-group-row-col">
-            <input class="long-text-field" type="text" placeholder="Enter URL" pInputText formControlName="listingUrl"
-                id="listingUrl" name="listingUrl" required />
+            <input class="long-text-field" type="text" placeholder="Enter URL beginning with http…" pInputText
+                formControlName="listingUrl" id="listingUrl" name="listingUrl" required />
         </div>
         <div class="form-group-row-col validation-errors"
             *ngIf="!listingUrlControl.pristine && listingUrlControl.errors">

diff --git a/frontend/src/app/features/components/delisting-request/delisting-request.component.ts b/frontend/src/app/features/components/delisting-request/delisting-request.component.ts
@@ -142,7 +142,6 @@ export class DelistingRequestComponent implements OnInit {
 
   private initForm(): void {
     this.myForm = this.fb.group({
-      lgId: [0, Validators.required],
       platformId: [0, Validators.required],
       listingId: [''],
       listingUrl: ['', [Validators.required, validateUrl()]],