Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue #222: Hide status fields and delete btn. Add Cancel btn. #241

Merged
merged 6 commits into from
Nov 29, 2023

Conversation

gurjinder12
Copy link
Contributor

No description provided.

@joel-osc
Copy link
Contributor

Not a fan of this implementation... browser back button is not reliable. Why not do it the same way as in RSAMS?

@gurjinder12
Copy link
Contributor Author

Not a fan of this implementation... browser back button is not reliable. Why not do it the same way as in RSAMS?

I can set custom submit handle on cancel btn and handle will have formstate->setRedirect, but that will not work if one of the field is empty and required.

@joel-osc
Copy link
Contributor

Why not just add the cancel_button module like on rsams???

@gurjinder12
Copy link
Contributor Author

gurjinder12 commented Nov 23, 2023

Why not just add the cancel_button module like on rsams???

OK adding cancel_button module, I update the code and it kind of doing same.

@gurjinder12 gurjinder12 force-pushed the 222-theme-individual-build branch from fad8e52 to dde5bdc Compare November 23, 2023 03:15
@lkmorlan lkmorlan linked an issue Nov 23, 2023 that may be closed by this pull request
8 tasks
@gurjinder12 gurjinder12 marked this pull request as draft November 23, 2023 15:15
@lkmorlan lkmorlan changed the title 222 - hide status fields and delete btn. Added Cancel btn. Issue #222: Hide status fields and delete btn. Add Cancel btn. Nov 23, 2023
@gurjinder12 gurjinder12 force-pushed the 222-theme-individual-build branch 2 times, most recently from 428a00c to 65107b6 Compare November 29, 2023 17:51
@gurjinder12 gurjinder12 marked this pull request as ready for review November 29, 2023 17:52
@lkmorlan lkmorlan force-pushed the 222-theme-individual-build branch from 65107b6 to 1d68766 Compare November 29, 2023 18:49
@lkmorlan lkmorlan merged commit e1221e0 into 1.0.x Nov 29, 2023
1 check passed
@lkmorlan lkmorlan deleted the 222-theme-individual-build branch November 29, 2023 21:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Theme individial build section edit pages
3 participants