code review corrections.

bcgov · Nov 6, 2024 · 689c803 · 689c803
1 parent d05c1c3
commit 689c803
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 3 deletions.
diff --git a/source/frontend/src/components/common/mapFSM/machineDefinition/mapMachine.ts b/source/frontend/src/components/common/mapFSM/machineDefinition/mapMachine.ts
@@ -85,6 +85,9 @@ const featureDataLoaderStates = {
           }),
           target: 'loading',
         },
+        SET_REFRESH_MAP_LAYERS: {
+          actions: assign({ mapLayersToRefresh: (_, event: any) => event.refreshLayers }),
+        },
       },
     },
     loading: {

diff --git a/source/frontend/src/components/maps/leaflet/Control/LayersControl/data.ts b/source/frontend/src/components/maps/leaflet/Control/LayersControl/data.ts
@@ -2,7 +2,7 @@ import { MAP_MAX_NATIVE_ZOOM, MAP_MAX_ZOOM } from '@/constants/strings';
 
 import { ILayerItem } from './types';
 
-export const PIMS_PROPERTY_BOUNDARY_KEY = 'pims_properties';
+export const PIMS_PROPERTY_BOUNDARY_KEY = 'PIMS_PROPERTY_BOUNDARY_KEY';
 
 export const layersTree: ILayerItem[] = [
   {

diff --git a/source/frontend/src/components/maps/leaflet/Layers/LeafletLayerListener.tsx b/source/frontend/src/components/maps/leaflet/Layers/LeafletLayerListener.tsx
@@ -4,6 +4,7 @@ import { useEffect } from 'react';
 import { useMap } from 'react-leaflet';
 
 import { useMapStateMachine } from '@/components/common/mapFSM/MapStateMachineContext';
+import useDeepCompareEffect from '@/hooks/util/useDeepCompareEffect';
 import { exists } from '@/utils';
 
 import { wmsHeaders } from '../Control/LayersControl/wmsHeaders';
@@ -23,7 +24,7 @@ export const LeafletLayerListener = () => {
     };
   }, [mapInstance]);
 
-  useEffect(() => {
+  useDeepCompareEffect(() => {
     if (mapLayersToRefresh?.length) {
       const currentLayers = featureGroup.getLayers().filter(exists);
       mapLayersToRefresh.forEach(configLayer => {
@@ -39,7 +40,6 @@ export const LeafletLayerListener = () => {
   }, [mapInstance, mapLayersToRefresh, setMapLayersToRefresh]);
 
   useEffect(() => {
-    console.log(featureGroup.getLayers());
     if (mapInstance) {
       const currentLayers = featureGroup.getLayers().filter(exists);
       const mapLayers = flatten(activeLayers.map(l => l.nodes));