disposition merge to dev, dotnet 8 update, ef update. #3682
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
frontend/backend now use typings to better reflect desired use of field (id timestamp vs dateonly).
* Provide Missing Seed Scripts for Alter Up in IS-65.00 - 134_DML_PIMS_PROP_MGMT_ACTIVITY_STATUS_TYPE.sql - 135_DML_PIMS_PROP_MGMT_ACTIVITY_TYPE.sql - 136_DML_PIMS_PROP_MGMT_ACTIVITY_SUBTYPE.sql * Updated Alter Scripts * IS-66.00 Database Schema PSP_PIMS S66.00 Sprint 65 2023-Oct-24 - Added tables: - PIMS_PROJECT_PRODUCT - PIMS_PROJECT_PRODUCT_HIST - PIMS_PROPERTY_ACTIVITY_DOCUMENT - PIMS_PROPERTY_ACTIVITY_DOCUMENT_HIST - Altered tables: - PIMS_PRODUCT - PIMS_PRODUCT_HIST - PIMS_TAKE - PIMS_TAKE_HIST - Dropped tables: - PIMS_PROP_PROP_CLASSIFICATION_HIST - Added test scripts: - 057_PIMS_PROJECT_PRODUCT.sql - 058_PIMS_TAKE.sql - Altered test scripts: - 040_PIMS_PRODUCT.sql - 048_PIMS_COMPENSATION_REQUISITION.sql - Requires additional metadata to meet standards * Modified Alter_Up * IS-68.00 Database Schema - Disposition File PSP_PIMS S68.00 Disposition Sprint 67 2023-Nov-22 - Added tables: - PIMS_DISPOSITION_FILE - PIMS_DISPOSITION_FILE_HIST - PIMS_DISPOSITION_FILE_STATUS_TYPE - PIMS_DISPOSITION_FILE_TEAM - PIMS_DISPOSITION_FILE_TEAM_HIST - PIMS_DISPOSITION_FUNDING_TYPE - PIMS_DISPOSITION_INITIATING_DOC_TYPE - PIMS_DISPOSITION_STATUS_TYPE - PIMS_DISPOSITION_TYPE - PIMS_DSP_FL_TEAM_PROFILE_TYPE - PIMS_DSP_INITIATING_BRANCH_TYPE - PIMS_DSP_PHYS_FILE_STATUS_TYPE - PIMS_PROPERTY_DISPOSITION_FILE - PIMS_PROPERTY_DISPOSITION_FILE_HIST - Added seed scripts: - 138_DML_PIMS_DISPOSITION_FILE_STATUS_TYPE.sql - 139_DML_PIMS_DISPOSITION_STATUS_TYPE.sql - 140_DML_PIMS_DISPOSITION_TYPE.sql - 141_DML_PIMS_DISPOSITION_INITIATING_DOC_TYPE.sql - 142_DML_PIMS_DSP_PHYS_FILE_STATUS_TYPE.sql - 143_DML_PIMS_DSP_INITIATING_BRANCH_TYPE.sql - 144_DML_PIMS_DSP_FL_TEAM_PROFILE_TYPE.sql - 145_DML_PIMS_DISPOSITION_FUNDING_TYPE.sql - Added test scripts: - 060_PIMS_DISPOSITION_FILE.sql - 061_PIMS_PROPERTY_DISPOSITION_FILE.sql - 062_PIMS_DISPOSITION_FILE_TEAM.sql - Requires additional metadata to meet standards --------- Co-authored-by: Manuel Rodriguez <[email protected]>
* Generated scaffold * Scaffolded
Co-authored-by: Eduardo Herrera <[email protected]>
* psp-7281 disposition file framework. * test corrections * lint correction. * code review corrections. * correct input mapping. * correct typo.
* Added check status logic when updating acq and related entities | psp-7006 (bcgov#3602) * Added status checking to details, take, compensation and other acq file pages * Updated backend and updated tests * Fixed lint * Refactored solver to be simpler * Added tests * Pr comments * Added the sys-admin to edit acquisition fields * CI: Bump version to v4.0.0-67.24 --------- Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
* Created disposition tray file * Added dispoisiton claims
…up code. (bcgov#3619) Co-authored-by: Smith <[email protected]>
* psp-6949 view disposition file summary. * update keycloak test url. --------- Co-authored-by: Smith <[email protected]>
* Disposition List - basic view, styles and models * Move and rename common list view component * Refactor expandable file properties into common component * Wire up disposition results sub-component * Disposition list filter component * Implement disposition search controller. - updates to service and repository - model updates * Enable frontend routing to disposition list view * Add service call to disposition search endpoint * Load lookup codes, team members into disposition list filter * Add new endpoint for list of team members * Backend mapping fixes * Add missing lookup table * Use the right lookup tables for filtering disposition list * Fix formik field name * Implement remaining filters * Fix merge conflict * Fix number conversion bug * Fix sorting issues on disposition list * PR feedback
* Added check status logic when updating acq and related entities | psp-7006 (bcgov#3602) * Added status checking to details, take, compensation and other acq file pages * Updated backend and updated tests * Fixed lint * Refactored solver to be simpler * Added tests * Pr comments * Added the sys-admin to edit acquisition fields * CI: Bump version to v4.0.0-67.24 * Updated placeholder display (bcgov#3620) * CI: Bump version to v4.0.0-67.25 * dialog correction. (bcgov#3629) Co-authored-by: Smith <[email protected]> * CI: Bump version to v4.0.0-67.26 * Keycloak Refactor (bcgov#3624) * Refactored keycloak sync to use the keycloak repository used by the API. ALso removed tools.Core and removed redundant models * pr fixes * CI: Bump version to v4.0.0-67.27 * System error modal | psp-7304 (bcgov#3628) * Updated Generic modal to use a variant * Improved System error modal * Lit fixes * Info fixes * CI: Bump version to v4.0.0-67.28 * psp-7346 correct bracket usage, ensure logic limited to file close only. (bcgov#3622) * psp-7346 correct bracket usage, ensure logic limited to file close only. * comment from code review. * test correction. --------- Co-authored-by: Smith <[email protected]> * CI: Bump version to v4.0.0-67.29 * requested source marked as nullable for validation. (bcgov#3630) Co-authored-by: Smith <[email protected]> * CI: Bump version to v4.0.0-67.30 * allow showing the edit screen for management activity while the popout is open. (bcgov#3632) Co-authored-by: Smith <[email protected]> * CI: Bump version to v4.0.0-67.31 * Pims api to Frontend ts generator and generated files (bcgov#3618) * Refactored concept models. Created a new library and cleaned dependencies between projects. Cleaned names of reused concepts and standarized concept namespace. Cleaned extension and help files * Fixed lints * Initial generator work * Cleaned up files and improved translation * Updated namespaces and path for the api models * Updated generator and cleaned up code * Added make command to generate ts api files and lint them. * First generation of the pims api. * Cleaned up generator and handled generic types. Improved header docks. * Fixed solution * Updated models for keycloak sync and fixed lint warnings * Fixed registering mappers * CI: Bump version to v4.0.0-67.32 * Bump DEV version - IS68 (bcgov#3636) * CI: Bump version to v4.0.0-68.1 * Manual merges and re-generated snaps * moved disposition models to the new api-models project * re-generated api models * Changed disposition property to property model type --------- Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: devinleighsmith <[email protected]> Co-authored-by: Smith <[email protected]> Co-authored-by: Alejandro Sanchez <[email protected]>
* Added check status logic when updating acq and related entities | psp-7006 (bcgov#3602) * Added status checking to details, take, compensation and other acq file pages * Updated backend and updated tests * Fixed lint * Refactored solver to be simpler * Added tests * Pr comments * Added the sys-admin to edit acquisition fields * CI: Bump version to v4.0.0-67.24 * Updated placeholder display (bcgov#3620) * CI: Bump version to v4.0.0-67.25 * Added the disposition entry into the menu list --------- Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
* Disposition backend unit tests * Frontend unit tests * Update mock lookup codes * Additional frontend tests * Revert mock roles (will create tech-debt to fix those) * Update snapshots * Update snapshots
* IS-69.00 Database Schema PSP_PIMS S69.00 Sprint 69 2023-Dec-06 - Added tables: - PIMS_DISPOSITION_CHECKLIST_ITEM - PIMS_DISPOSITION_CHECKLIST_ITEM_HIST - PIMS_DISPOSITION_FILE - PIMS_DISPOSITION_FILE_HIST - PIMS_DISPOSITION_FILE_DOCUMENT - PIMS_DISPOSITION_FILE_DOCUMENT_HIST - PIMS_DISPOSITION_FILE_NOTE - PIMS_DISPOSITION_FILE_NOTE_HIST - PIMS_DISPOSITION_FILE_PROPERTY - PIMS_DISPOSITION_FILE_PROPERTY_HIST - PIMS_DISPOSITION_FILE_STATUS_TYPE - PIMS_DISPOSITION_FILE_TEAM - PIMS_DISPOSITION_FILE_TEAM_HIST - PIMS_DISPOSITION_FUNDING_TYPE - PIMS_DISPOSITION_INITIATING_DOC_TYPE - PIMS_DISPOSITION_OFFER - PIMS_DISPOSITION_OFFER_HIST - PIMS_DISPOSITION_OFFER_STATUS_TYPE - PIMS_DISPOSITION_PURCHASER - PIMS_DISPOSITION_PURCHASER_HIST - PIMS_DISPOSITION_SALE - PIMS_DISPOSITION_SALE_HIST - PIMS_DISPOSITION_STATUS_TYPE - PIMS_DISPOSITION_TYPE - PIMS_DSP_CHKLST_ITEM_STATUS_TYPE - PIMS_DSP_CHKLST_ITEM_TYPE - PIMS_DSP_CHKLST_SECTION_TYPE - PIMS_DSP_FL_TEAM_PROFILE_TYPE - PIMS_DSP_INITIATING_BRANCH_TYPE - PIMS_DSP_PHYS_FILE_STATUS_TYPE - PIMS_DSP_PURCH_AGENT - PIMS_DSP_PURCH_AGENT_HIST - PIMS_DSP_PURCH_SOLICITOR - PIMS_DSP_PURCH_SOLICITOR_HIST - Added seed scripts: - 138_DML_PIMS_DISPOSITION_FILE_STATUS_TYPE.sql - 139_DML_PIMS_DISPOSITION_STATUS_TYPE.sql - 140_DML_PIMS_DISPOSITION_TYPE.sql - 141_DML_PIMS_DISPOSITION_INITIATING_DOC_TYPE.sql - 142_DML_PIMS_DSP_PHYS_FILE_STATUS_TYPE.sql - 143_DML_PIMS_DSP_INITIATING_BRANCH_TYPE.sql - 144_DML_PIMS_DSP_FL_TEAM_PROFILE_TYPE.sql - 145_DML_PIMS_DISPOSITION_FUNDING_TYPE.sql - 146_DML_PIMS_DSP_CHKLST_ITEM_STATUS_TYPE.sql - 147_DML_PIMS_DSP_CHKLST_SECTION_TYPE.sql - 148_DML_PIMS_DSP_CHKLST_ITEM_TYPE.sql - 149_DML_PIMS_DISPOSITION_OFFER_STATUS_TYPE.sql - Altered seed scripts: - 128_DML_PIMS_LAND_ACT_TYPE.sql - Added test scripts: - 060_PIMS_DISPOSITION_FILE.sql - 061_PIMS_DISPOSITION_FILE_PROPERTY.sql - 062_PIMS_DISPOSITION_FILE_TEAM.sql - 063_PIMS_DISPOSITION_FILE_NOTE.sql - 064_PIMS_DISPOSITION_FILE_DOCUMENT.sql - 065_PIMS_DISPOSITION_OFFER.sql - 066_PIMS_DISPOSITION_SALE.sql - 067_PIMS_DISPOSITION_PURCHASER.sql - 068_PIMS_DSP_PURCH_SOLICITOR.sql - 069_PIMS_DSP_PURCH_AGENT.sql - 070_PIMS_DISPOSITION_CHECKLIST_ITEM.sql - Requires additional metadata to meet standards * Static Variable Version Corrected * Renamed folder to make it work with cml * Updated test scripts * Moved 69 changes to 68 folder * Update test notes and checklist --------- Co-authored-by: Manuel Rodriguez <[email protected]>
Co-authored-by: Eduardo Herrera <[email protected]>
Disposition alignment from Dev
* Add disposition file document repository * Update document relationship constants and mappings * Document service updates * Document controller updates and permission fixes * Add documents to disposition file frontend * Fix typo * Minor corrections * Align permissions for deleting documents * Add backend unit tests * Update snapshots
* psp-6955 add disposition notes. * test corrections. * merge corrections.
* PSP-7269 create disposition from map * Test updates
Co-authored-by: Eduardo Herrera <[email protected]>
# Conflicts: # source/backend/api/Areas/Keycloak/Mapping/AccessRequest/AccessRequestOrganizationMap.cs # source/backend/api/Areas/Keycloak/Mapping/AccessRequest/AccessRequestUserMap.cs # source/backend/api/Areas/Keycloak/Mapping/User/UserMap.cs # source/backend/api/Areas/Reports/Mapping/User/UserMap.cs # source/backend/api/Mapping/User/UserMap.cs # source/backend/api/Pims.Api.csproj # source/backend/api/Services/CompensationRequisitionService.cs # source/backend/apimodels/Models/Base/TypeMap.cs # source/backend/apimodels/Models/Concepts/AcquisitionFile/AgreementMap.cs # source/backend/apimodels/Models/Concepts/AcquisitionFile/AgreementModel.cs # source/backend/apimodels/Models/Concepts/Note/NoteMap.cs # source/backend/apimodels/Models/Concepts/Take/TakeMap.cs # source/backend/entities/PimsBaseContext.cs # source/backend/entities/ef/PimsDispositionFile.cs # source/backend/entities/ef/PimsDispositionFileHist.cs # source/backend/entities/ef/PimsDispositionFileStatusType.cs # source/backend/entities/ef/PimsDispositionFileTeam.cs # source/backend/entities/ef/PimsDispositionFileTeamHist.cs # source/backend/entities/ef/PimsDispositionFundingType.cs # source/backend/entities/ef/PimsDispositionInitiatingDocType.cs # source/backend/entities/ef/PimsDispositionStatusType.cs # source/backend/entities/ef/PimsDispositionType.cs # source/backend/entities/ef/PimsDocument.cs # source/backend/entities/ef/PimsDspFlTeamProfileType.cs # source/backend/entities/ef/PimsDspInitiatingBranchType.cs # source/backend/entities/ef/PimsDspPhysFileStatusType.cs # source/backend/entities/ef/PimsNote.cs # source/backend/entities/ef/PimsOrganization.cs # source/backend/entities/ef/PimsPerson.cs # source/backend/entities/ef/PimsProperty.cs # source/backend/entities/ef/PimsRegion.cs # source/frontend/src/models/api/Agreement.ts
|
✅ No secrets were detected in the code. |
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## dev #3682 +/- ##
==========================================
+ Coverage 69.62% 71.49% +1.87%
==========================================
Files 1373 1423 +50
Lines 34438 36146 +1708
Branches 6489 6775 +286
==========================================
+ Hits 23977 25843 +1866
+ Misses 10204 10038 -166
- Partials 257 265 +8
Flags with carried forward coverage won't be shown. Click here to find out more.
|
|
✅ No secrets were detected in the code. |
|
✅ No secrets were detected in the code. |
|
✅ No secrets were detected in the code. |
|
✅ No secrets were detected in the code. |
|
@eddherrera please review this when possible. |
|
✅ No secrets were detected in the code. |
Looks good, the only change I had to make to make it work on my local was the following setting to the connection string for the .env file. Otherwise I get connections errors to the database.
|
eddherrera
approved these changes
Jan 2, 2024
|
✅ No secrets were detected in the code. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.