Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Psp 6953 disposition checklist and generic checklist components. #3694

Merged
merged 2 commits into from
Jan 4, 2024

Conversation

devinleighsmith
Copy link
Collaborator

No description provided.

@devinleighsmith devinleighsmith added the enhancement New feature or request label Jan 3, 2024
@devinleighsmith devinleighsmith self-assigned this Jan 3, 2024
Copy link
Contributor

github-actions bot commented Jan 3, 2024

✅ No secrets were detected in the code.

1 similar comment
Copy link
Contributor

github-actions bot commented Jan 3, 2024

✅ No secrets were detected in the code.

Copy link

codecov bot commented Jan 4, 2024

Codecov Report

Attention: 36 lines in your changes are missing coverage. Please review.

Comparison is base (e0fe919) 71.34% compared to head (c319272) 71.22%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##              dev    #3694      +/-   ##
==========================================
- Coverage   71.34%   71.22%   -0.12%     
==========================================
  Files        1426     1431       +5     
  Lines       36441    36621     +180     
  Branches     6817     6834      +17     
==========================================
+ Hits        25999    26084      +85     
- Misses      10174    10267      +93     
- Partials      268      270       +2     
Flag Coverage Δ
unittests 71.22% <85.65%> (-0.12%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
...eas/Acquisition/Controllers/ChecklistController.cs 100.00% <100.00%> (ø)
...eas/Disposition/Controllers/ChecklistController.cs 100.00% <100.00%> (ø)
source/backend/api/Controllers/LookupController.cs 100.00% <100.00%> (ø)
...kend/api/Helpers/Extensions/PrincipalExtensions.cs 70.00% <ø> (ø)
...rce/backend/api/Services/AcquisitionFileService.cs 74.13% <100.00%> (ø)
...AcquisitionFile/AcquisitionFileChecklistItemMap.cs 100.00% <100.00%> (ø)
...isitionFile/AcquisitionFileChecklistItemTypeMap.cs 100.00% <100.00%> (ø)
...els/Concepts/AcquisitionFile/AcquisitionFileMap.cs 100.00% <100.00%> (ø)
...DispositionFile/DispositionFileChecklistItemMap.cs 100.00% <100.00%> (ø)
...ositionFile/DispositionFileChecklistItemTypeMap.cs 100.00% <100.00%> (ø)
... and 28 more

... and 6 files with indirect coverage changes

@eddherrera eddherrera self-requested a review January 4, 2024 17:00
@@ -1,4 +1,5 @@
using System.Collections.Generic;
using DocumentFormat.OpenXml.InkML;
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is this for?

Copy link
Contributor

github-actions bot commented Jan 4, 2024

✅ No secrets were detected in the code.

@devinleighsmith devinleighsmith merged commit e4b956c into bcgov:dev Jan 4, 2024
8 of 9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants