Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

psp-7726 guarantee same view/edit order by using id instead of timestamp. Ther… #3783

Merged
merged 6 commits into from
Feb 9, 2024

Conversation

devinleighsmith
Copy link
Collaborator

…e is no guarantee on insert order so rename take title during add.

@devinleighsmith devinleighsmith added the bug Something isn't working label Feb 9, 2024
@devinleighsmith devinleighsmith self-assigned this Feb 9, 2024
Copy link
Contributor

github-actions bot commented Feb 9, 2024

✅ No secrets were detected in the code.

Copy link

codecov bot commented Feb 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (55086c7) 75.69% compared to head (7427a92) 74.12%.

❗ Current head 7427a92 differs from pull request most recent head 869ea35. Consider uploading reports for the commit 869ea35 to get more accurate results

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##              dev    #3783      +/-   ##
==========================================
- Coverage   75.69%   74.12%   -1.58%     
==========================================
  Files        1446      955     -491     
  Lines       38080    20803   -17277     
  Branches     7154     6021    -1133     
==========================================
- Hits        28826    15420   -13406     
+ Misses       8967     5383    -3584     
+ Partials      287        0     -287     
Flag Coverage Δ
unittests 74.12% <100.00%> (-1.58%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
...roperty/tabs/takes/detail/TakesDetailContainer.tsx 100.00% <100.00%> (ø)
...SideBar/property/tabs/takes/update/TakeSubForm.tsx 78.20% <100.00%> (+0.28%) ⬆️
...roperty/tabs/takes/update/TakesUpdateContainer.tsx 100.00% <100.00%> (ø)
...Bar/property/tabs/takes/update/TakesUpdateForm.tsx 100.00% <100.00%> (ø)

... and 491 files with indirect coverage changes

Copy link
Contributor

github-actions bot commented Feb 9, 2024

✅ No secrets were detected in the code.

Copy link
Contributor

github-actions bot commented Feb 9, 2024

✅ No secrets were detected in the code.

1 similar comment
Copy link
Contributor

github-actions bot commented Feb 9, 2024

✅ No secrets were detected in the code.

Copy link
Contributor

github-actions bot commented Feb 9, 2024

✅ No secrets were detected in the code.

1 similar comment
Copy link
Contributor

github-actions bot commented Feb 9, 2024

✅ No secrets were detected in the code.

Copy link
Contributor

github-actions bot commented Feb 9, 2024

✅ No secrets were detected in the code.

1 similar comment
Copy link
Contributor

github-actions bot commented Feb 9, 2024

✅ No secrets were detected in the code.

@devinleighsmith devinleighsmith merged commit b48292d into bcgov:dev Feb 9, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants