Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PSP-7655 advanced map filter for property ownership. PSP-7585 #3785

Merged
merged 6 commits into from
Feb 12, 2024

Conversation

asanchezr
Copy link
Collaborator

Default Filter

default-ownership-filter

Property of Interest

poi-filter

Other Interests

other-interest-filter

@asanchezr asanchezr added the enhancement New feature or request label Feb 10, 2024
@asanchezr asanchezr self-assigned this Feb 10, 2024
Copy link
Contributor

✅ No secrets were detected in the code.

Copy link

codecov bot commented Feb 10, 2024

Codecov Report

Attention: 8 lines in your changes are missing coverage. Please review.

Comparison is base (bb651da) 75.58% compared to head (ebc986a) 75.58%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##              dev    #3785      +/-   ##
==========================================
- Coverage   75.58%   75.58%   -0.01%     
==========================================
  Files        1448     1449       +1     
  Lines       38373    38405      +32     
  Branches     7271     7280       +9     
==========================================
+ Hits        29006    29030      +24     
- Misses       9073     9081       +8     
  Partials      294      294              
Flag Coverage Δ
unittests 75.58% <76.47%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
...ource/backend/dal/Models/PropertyFilterCriteria.cs 100.00% <100.00%> (ø)
...rce/backend/dal/Repositories/PropertyRepository.cs 92.00% <100.00%> (+0.09%) ⬆️
.../Control/AdvancedFilter/FilterContentContainer.tsx 100.00% <100.00%> (ø)
...aflet/Control/AdvancedFilter/FilterContentForm.tsx 100.00% <100.00%> (ø)
...ents/maps/leaflet/Control/AdvancedFilter/models.ts 79.16% <100.00%> (+4.16%) ⬆️
...c/components/maps/leaflet/Markers/SingleMarker.tsx 72.72% <100.00%> (ø)
...tend/src/models/layers/pimsPropertyLocationView.ts 100.00% <ø> (ø)
...ents/common/mapFSM/machineDefinition/mapMachine.ts 13.46% <0.00%> (-0.27%) ⬇️
...omponents/common/mapFSM/MapStateMachineContext.tsx 40.95% <33.33%> (-0.23%) ⬇️
...ontend/src/components/maps/leaflet/Layers/util.tsx 72.64% <61.53%> (-1.56%) ⬇️

@asanchezr asanchezr force-pushed the psp-7655-map-filter-disposed branch from a8d7cd5 to d3742f2 Compare February 10, 2024 00:37
Copy link
Contributor

✅ No secrets were detected in the code.

@asanchezr asanchezr force-pushed the psp-7655-map-filter-disposed branch from d3742f2 to ebc986a Compare February 11, 2024 20:24
Copy link
Contributor

✅ No secrets were detected in the code.

@asanchezr
Copy link
Collaborator Author

Remaining scope (PSP-7585) implemented in this PR as well. It is now ready for review
disposed-map-pin

@asanchezr asanchezr merged commit d17d4a3 into bcgov:dev Feb 12, 2024
9 checks passed
@asanchezr asanchezr changed the title PSP-7655 advanced map filter for property ownership PSP-7655 advanced map filter for property ownership. PSP-7585 Feb 12, 2024
@asanchezr asanchezr deleted the psp-7655-map-filter-disposed branch February 13, 2024 00:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants