-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
psp-7607 correct creating file from orange marker not working properly. #3787
Conversation
✅ No secrets were detected in the code. |
1 similar comment
✅ No secrets were detected in the code. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## dev #3787 +/- ##
==========================================
- Coverage 75.58% 74.02% -1.57%
==========================================
Files 1449 956 -493
Lines 38405 20997 -17408
Branches 7280 6120 -1160
==========================================
- Hits 29030 15543 -13487
+ Misses 9081 5454 -3627
+ Partials 294 0 -294
Flags with carried forward coverage won't be shown. Click here to find out more.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
do we need geoserver config changes or did your local env leaked?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
will remove, something weird going on with my geoserver container
@@ -70,3 +70,78 @@ export const mockFAParcelLayerResponse = { | |||
}, | |||
bbox: [-132.1709, 48.3528, -114.6927, 56.8488], | |||
}; | |||
|
|||
export const mockFAParcelLayerResponseMultiPolygon = { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lets strongly type mocks so we can guarantee that it matches what is coming from the pipe, assuming you used a real sample and the internal checks can live past modifications to the model
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
updated.
2f7af8f
to
a24972e
Compare
a24972e
to
6810267
Compare
✅ No secrets were detected in the code. |
1 similar comment
✅ No secrets were detected in the code. |
No description provided.