Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PSP-7868 invalid map pin logic. PSP-7872 #3813

Merged
merged 4 commits into from
Feb 26, 2024

Conversation

asanchezr
Copy link
Collaborator

No description provided.

@asanchezr asanchezr added the bug Something isn't working label Feb 23, 2024
@asanchezr asanchezr self-assigned this Feb 23, 2024
Copy link
Contributor

✅ No secrets were detected in the code.

@asanchezr asanchezr force-pushed the psp-7868-invalid-map-pin-logic branch from d2cc6a7 to ae25b97 Compare February 23, 2024 01:34
Copy link
Contributor

✅ No secrets were detected in the code.

Copy link
Contributor

✅ No secrets were detected in the code.

Copy link

codecov bot commented Feb 23, 2024

Codecov Report

Attention: Patch coverage is 72.72727% with 3 lines in your changes are missing coverage. Please review.

Project coverage is 74.01%. Comparing base (4ada249) to head (b27e17d).

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##              dev    #3813      +/-   ##
==========================================
- Coverage   75.42%   74.01%   -1.42%     
==========================================
  Files        1415      936     -479     
  Lines       38470    21314   -17156     
  Branches     7908     6745    -1163     
==========================================
- Hits        29015    15775   -13240     
+ Misses       9161     5539    -3622     
+ Partials      294        0     -294     
Flag Coverage Δ
unittests 74.01% <72.72%> (-1.42%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
.../disposition/form/DispositionPropertiesSubForm.tsx 33.33% <ø> (ø)
...ontend/src/components/maps/leaflet/Layers/util.tsx 79.04% <72.72%> (ø)

... and 479 files with indirect coverage changes

Copy link
Contributor

✅ No secrets were detected in the code.

@asanchezr asanchezr merged commit a9643e8 into bcgov:dev Feb 26, 2024
9 checks passed
@asanchezr asanchezr deleted the psp-7868-invalid-map-pin-logic branch February 29, 2024 01:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants