5.7 release to UAT #4565

devinleighsmith · 2025-01-02T09:36:41Z

No description provided.

* Bump version IS-96 * Lint fixes

PSP_PIMS | Development Sprint: S96.00 | Design Sprint: 95 | Date: 2024-Dec-17 - Added tables: - PIMS_ACQ_FILE_ACQ_FL_TAKE_TYP - PIMS_ACQ_FILE_ACQ_FL_TAKE_TYP_HIST - PIMS_ACQ_FILE_ACQ_PROGRESS - PIMS_ACQ_FILE_ACQ_PROGRESS_HIST - PIMS_ACQ_FILE_APPRAISAL_TYPE - PIMS_ACQ_FILE_EXPROP_RISK_TYPE - PIMS_ACQ_FILE_LGL_SRVY_TYPE - PIMS_ACQ_FILE_PROGESS_TYPE - PIMS_ACQ_FILE_TAKE_TYPE - Altered tables: - PIMS_ACQUISITION_FILE - PIMS_ACQUISITION_FILE_HIST - PIMS_ACQ_CHKLST_SECTION_TYPE - PIMS_DOCUMENT - PIMS_DOCUMENT_QUEUE - PIMS_DOCUMENT_QUEUE_HIST - PIMS_PROJECT_PERSON - PIMS_PROJECT_PERSON_HIST - PIMS_PROPERTY - Added seed scripts: - 159_DML_PIMS_ACQ_FILE_PROGESS_TYPE.sql - 160_DML_PIMS_ACQ_FILE_APPRAISAL_TYPE.sql - 161_DML_PIMS_ACQ_FILE_LGL_SRVY_TYPE.sql - 162_DML_PIMS_ACQ_FILE_TAKE_TYPE.sql - 163_DML_PIMS_ACQ_FILE_EXPROP_RISK_TYPE.sql - Requires additional metadata to meet standards Co-authored-by: Manuel Rodriguez <[email protected]>

PSP-9710, PSP-9313: UI/UX Cleanup - Make icons consistent across PIMS

PSP-9211 and PSP-9719: UI/UX Clean up: Map Icons Replacement and PIMS File header colors

…_dev

Backmerge test into dev

* Address race condition where: 1) (thread #1) upload document action starts upload, sets document to processing 2) (thread #2) document poll starts executing with document in processing state 3) (thread #1) upload document action completes upload, sets document to sucess. 4) (thread #2) document poll throws concurrency exception. * correction. * test updates.

Co-authored-by: Herrera <[email protected]> Co-authored-by: devinleighsmith <[email protected]>

… Form

PSP-9471: UI UX Clean Up - Contact – Manage Contacts: Allow to save contacts that are set as Inactive without Contact Methods

* fix infinite render loop caused by hasClaim function. * formatting fixes.

* reduce round trips to database, add capability for database to retry transitive failures. * Correct job name in appsettings - to ensure correct scheduled interval. * test corrections.

… details after user adds the Project Team member (#4563) Co-authored-by: Herrera <[email protected]>

github-actions · 2025-01-02T09:43:41Z

See CodeCov Report Here: https://app.codecov.io/github/bcgov/psp/pull/4565

github-actions · 2025-01-02T09:50:17Z

See CodeCov Report Here: https://app.codecov.io/github/bcgov/psp/pull/4565

…toral District (#4564) * Code cleanup * PSP-9683 Return compensation property locations in lat/long * Test updates

github-actions · 2025-01-02T10:25:02Z

See CodeCov Report Here: https://app.codecov.io/github/bcgov/psp/pull/4565

github-actions · 2025-01-02T10:25:27Z

See CodeCov Report Here: https://app.codecov.io/github/bcgov/psp/pull/4565

codecov · 2025-01-02T10:26:31Z

Codecov Report

Attention: Patch coverage is 67.91569% with 137 lines in your changes missing coverage. Please review.

Project coverage is 86.74%. Comparing base (6362ad3) to head (b0e44af).
Report is 77 commits behind head on test.

Files with missing lines	Patch %	Lines
...end/api/Areas/Documents/DocumentQueueController.cs	0.00%	35 Missing ⚠️
...rce/backend/dal/Repositories/DocumentRepository.cs	29.16%	17 Missing ⚠️
...ackend/dal/Repositories/DocumentQueueRepository.cs	77.14%	13 Missing and 3 partials ⚠️
...ource/backend/dal/Repositories/LookupRepository.cs	0.00%	15 Missing ⚠️
...kend/dal/Repositories/AcquisitionFileRepository.cs	58.33%	8 Missing and 2 partials ⚠️
source/backend/api/Services/DocumentFileService.cs	74.28%	6 Missing and 3 partials ⚠️
source/backend/api/Services/DocumentService.cs	0.00%	8 Missing ⚠️
...pi/Helpers/Extensions/AcquisitionFileExtensions.cs	50.00%	3 Missing and 3 partials ⚠️
....api/Repositories/RestCommon/BaseRestRepository.cs	0.00%	3 Missing ⚠️
.../Repositories/AcquisitionFileDocumentRepository.cs	0.00%	3 Missing ⚠️
... and 11 more

Additional details and impacted files

@@            Coverage Diff             @@
##             test    #4565      +/-   ##
==========================================
+ Coverage   86.71%   86.74%   +0.03%     
==========================================
  Files        1659     1669      +10     
  Lines      141147   142918    +1771     
  Branches    10582    10679      +97     
==========================================
+ Hits       122390   123976    +1586     
- Misses      18416    18585     +169     
- Partials      341      357      +16

Flag	Coverage Δ
unittests	`86.74% <67.91%> (+0.03%)`	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines	Coverage Δ
...n/Controllers/CompensationRequisitionController.cs	`0.00% <ø> (ø)`
.../Areas/Documents/DocumentRelationshipController.cs	`0.00% <ø> (ø)`
source/backend/api/Controllers/LookupController.cs	`100.00% <100.00%> (ø)`
...rce/backend/api/Services/AcquisitionFileService.cs	`74.63% <100.00%> (+0.08%)`	⬆️
...end/api/Services/CompensationRequisitionService.cs	`71.08% <100.00%> (+3.32%)`	⬆️
...ource/backend/api/Services/DocumentQueueService.cs	`100.00% <100.00%> (+100.00%)`	⬆️
source/backend/api/Services/FormDocumentService.cs	`100.00% <100.00%> (ø)`
source/backend/api/Services/ResearchFileService.cs	`79.08% <100.00%> (ø)`
...ource/backend/apimodels/Models/Base/CodeTypeMap.cs	`100.00% <ø> (ø)`
...els/Concepts/AcquisitionFile/AcquisitionFileMap.cs	`100.00% <100.00%> (ø)`
... and 35 more

... and 64 files with indirect coverage changes

github-actions · 2025-01-02T10:30:44Z

See CodeCov Report Here: https://app.codecov.io/github/bcgov/psp/pull/4565

github-actions · 2025-01-02T10:31:04Z

See CodeCov Report Here: https://app.codecov.io/github/bcgov/psp/pull/4565

JamesPayer

UAT release 5.7

stairaku and others added 30 commits December 18, 2024 10:41

Changes for PSP-9710 and PSP-9313

834e092

Updated Snapshots and unit tests

8596065

Merging changes

fd26b49

Updating AgreementView.ts

189f5e8

Adding IDs to delete buttons on periodColumns.tsx

a1d974d

Bump version 96 (#4543)

49f675e

* Bump version IS-96 * Lint fixes

CI: Bump version to v5.7.0-96.1

fe5f5e4

CI: Bump version to v5.7.0-96.2

fec8cf7

generated scaffold (#4544)

08682bf

CI: Bump version to v5.7.0-96.3

6b2b7f3

Merge branch 'dev' into PSP-9710

aaf3c43

PSP-9211 and PSP-9719 fixes

a722faf

PSP-9471 fix

63df019

PSP-9471 unit test

7c580e6

Fix of PR observations

4a93957

Merge branch 'PSP-9710' of https://github.com/stairaku/PSP into PSP-9710

0b97e70

Changing data-testId props

e552cf1

Merge pull request #4541 from stairaku/PSP-9710

8aa0ab6

PSP-9710, PSP-9313: UI/UX Cleanup - Make icons consistent across PIMS

CI: Bump version to v5.7.0-96.4

7ad22ac

Merge branch 'bcgov:dev' into PSP-9211

d679429

Adding button element to fulfill unit tests

7f91f38

Merge branch 'PSP-9211' of https://github.com/stairaku/PSP into PSP-9211

8154368

Merge pull request #4546 from stairaku/PSP-9211

320668a

PSP-9211 and PSP-9719: UI/UX Clean up: Map Icons Replacement and PIMS File header colors

CI: Bump version to v5.7.0-96.5

8d5a0ba

Merge remote-tracking branch 'upstream/test' into backmerge_test_into…

4f9b1e0

…_dev

updates

eef09b5

Merge branch 'PSP-9471' of https://github.com/stairaku/PSP into PSP-9471

1f6c9bf

update unit tests

18d9c21

Merge pull request #4551 from asanchezr/backmerge_test_into_dev

6304a58

Backmerge test into dev

devinleighsmith and others added 17 commits December 30, 2024 13:34

CI: Bump version to v5.7.0-96.16

d6c46e4

PSP-9604 : Acquisition file- Progress statuses (#4554)

c262323

Co-authored-by: Herrera <[email protected]> Co-authored-by: devinleighsmith <[email protected]>

CI: Bump version to v5.7.0-96.17

a084d97

Merge branch 'bcgov:dev' into PSP-9471

350ae84

changes on organization and person status logic

c49de85

Merge branch 'PSP-9471' of https://github.com/stairaku/PSP into PSP-9471

b5b7326

Changes on contact models to convert isDisabled to string from Api to…

ce0c73f

… Form

Changes on contact models to convert isDisabled to string from Api to…

6da46e7

… Form

Merge pull request #4552 from stairaku/PSP-9471

102f2f4

PSP-9471: UI UX Clean Up - Contact – Manage Contacts: Allow to save contacts that are set as Inactive without Contact Methods

CI: Bump version to v5.7.0-96.18

31b1e80

Psp 9763 - infinite render loop (#4561)

80f9198

* fix infinite render loop caused by hasClaim function. * formatting fixes.

CI: Bump version to v5.7.0-96.19

7befa80

Psp 9512 - corrections/enhancements (#4562)

5bf92e9

* reduce round trips to database, add capability for database to retry transitive failures. * Correct job name in appsettings - to ensure correct scheduled interval. * test corrections.

CI: Bump version to v5.7.0-96.20

2981f65

PSP-9760 : FT:Projects: User is not able to update any of the project…

1bc3755

… details after user adds the Project Team member (#4563) Co-authored-by: Herrera <[email protected]>

CI: Bump version to v5.7.0-96.21

ba2043b

devinleighsmith added the release-management label Jan 2, 2025

devinleighsmith self-assigned this Jan 2, 2025

asanchezr and others added 2 commits January 2, 2025 02:17

PSP-9683 Generated H-120 Compensation Requisition not Populating Elec…

916a176

…toral District (#4564) * Code cleanup * PSP-9683 Return compensation property locations in lat/long * Test updates

CI: Bump version to v5.7.0-96.22

b0e44af

JamesPayer approved these changes Jan 2, 2025

View reviewed changes

JamesPayer merged commit c76126a into test Jan 2, 2025
47 of 52 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

5.7 release to UAT #4565

5.7 release to UAT #4565

devinleighsmith commented Jan 2, 2025

github-actions bot commented Jan 2, 2025

github-actions bot commented Jan 2, 2025

github-actions bot commented Jan 2, 2025

github-actions bot commented Jan 2, 2025

codecov bot commented Jan 2, 2025 •

edited

Loading

github-actions bot commented Jan 2, 2025

github-actions bot commented Jan 2, 2025

JamesPayer left a comment

5.7 release to UAT #4565

5.7 release to UAT #4565

Conversation

devinleighsmith commented Jan 2, 2025

github-actions bot commented Jan 2, 2025

github-actions bot commented Jan 2, 2025

github-actions bot commented Jan 2, 2025

github-actions bot commented Jan 2, 2025

codecov bot commented Jan 2, 2025 • edited Loading

Codecov Report

github-actions bot commented Jan 2, 2025

github-actions bot commented Jan 2, 2025

JamesPayer left a comment

Choose a reason for hiding this comment

codecov bot commented Jan 2, 2025 •

edited

Loading