-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PSP-8850 : PIMS performance analysis - DEV #4586
base: dev
Are you sure you want to change the base?
Conversation
See CodeCov Report Here: https://app.codecov.io/github/bcgov/psp/pull/4586 |
@eddherrera While I appreciate this PR, the task was primarily about identifying performance issues triaging, and creating follow up stories. During our Friday meeting, please take some time to go through your results for group discussion (apologies if this was already your plan). |
} | ||
|
||
MemoryCacheEntryOptions cacheOptions = new(); | ||
cacheOptions.SetSlidingExpiration(TimeSpan.FromHours(2)); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For this change, let's make this time controllable by configuration instead of hardcoding it.
@eddherrera this one still has an outstanding comment. |
See CodeCov Report Here: https://app.codecov.io/github/bcgov/psp/pull/4586 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think, as written, this is what will happen with our existing release process.
- we start our release GHA
- the images are tagged and the deployments restart.
- the mayan document types will be cached.
- the GHA will run the document type update.
So we will always need to restart the api again to see this change. Does that seem correct?
No description provided.