Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PSP-8850 : PIMS performance analysis - DEV #4586

Open
wants to merge 5 commits into
base: dev
Choose a base branch
from

Conversation

eddherrera
Copy link
Collaborator

No description provided.

@eddherrera eddherrera self-assigned this Jan 9, 2025
Copy link
Contributor

See CodeCov Report Here: https://app.codecov.io/github/bcgov/psp/pull/4586

@eddherrera eddherrera marked this pull request as ready for review January 13, 2025 20:35
@devinleighsmith
Copy link
Collaborator

@eddherrera While I appreciate this PR, the task was primarily about identifying performance issues triaging, and creating follow up stories. During our Friday meeting, please take some time to go through your results for group discussion (apologies if this was already your plan).

}

MemoryCacheEntryOptions cacheOptions = new();
cacheOptions.SetSlidingExpiration(TimeSpan.FromHours(2));
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For this change, let's make this time controllable by configuration instead of hardcoding it.

@devinleighsmith
Copy link
Collaborator

@eddherrera this one still has an outstanding comment.

Copy link
Contributor

See CodeCov Report Here: https://app.codecov.io/github/bcgov/psp/pull/4586

Copy link
Collaborator

@devinleighsmith devinleighsmith left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think, as written, this is what will happen with our existing release process.

  1. we start our release GHA
  2. the images are tagged and the deployments restart.
  3. the mayan document types will be cached.
  4. the GHA will run the document type update.

So we will always need to restart the api again to see this change. Does that seem correct?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants