Skip to content

Commit

Permalink
#3067 - Assessment History: Update to show most recent assessment (#4285
Browse files Browse the repository at this point in the history
)

### As a part of this PR, the following were completed:

- Added the TIME (HH:MM 24hr) to the Assessment date in the history
view.
- Ensured that the table is always ordered by submitted date descending.
- Confirmed that the changes apply to the Ministry view, Student view
and the Institution view.

### **Screenshots:**

**Institution View:**

<img width="1920" alt="image"
src="https://github.com/user-attachments/assets/d6e403ee-ddbc-4ca9-ab8a-e3e7410a1959"
/>

-------------------------------------------

**Student View:**

<img width="1920" alt="image"
src="https://github.com/user-attachments/assets/a606fa92-dea6-4f31-b87b-b925bcf43e05"
/>

-------------------------------------------

**Ministry View:**

<img width="1919" alt="image"
src="https://github.com/user-attachments/assets/f06ab9c6-bf40-44b9-875a-55089047e34e"
/>
  • Loading branch information
sh16011993 authored Jan 24, 2025
1 parent 6cdc2f8 commit 39048ae
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 4 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -275,8 +275,7 @@ export class StudentAssessmentService extends RecordDataModelService<StudentAsse
});
}
return assessmentHistoryQuery
.orderBy("assessment.studentAssessmentStatus", "DESC")
.addOrderBy("assessment.submittedDate", "DESC")
.orderBy("assessment.submittedDate", "DESC")
.getMany();
}

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -55,7 +55,7 @@
:sortable="true"
><template #body="slotProps">
<span v-if="slotProps.data.assessmentDate">{{
dateOnlyLongString(slotProps.data.assessmentDate)
getISODateHourMinuteString(slotProps.data.assessmentDate)
}}</span
><span v-else>-</span></template
></Column
Expand Down Expand Up @@ -116,7 +116,7 @@ export default defineComponent({
},
},
setup(props, context) {
const { dateOnlyLongString } = useFormatters();
const { dateOnlyLongString, getISODateHourMinuteString } = useFormatters();
const assessmentHistory = ref([] as AssessmentHistorySummaryAPIOutDTO[]);
onMounted(async () => {
assessmentHistory.value =
Expand Down Expand Up @@ -185,6 +185,7 @@ export default defineComponent({
PAGINATION_LIST,
assessmentHistory,
dateOnlyLongString,
getISODateHourMinuteString,
viewRequest,
canShowViewRequest,
getViewRequestLabel,
Expand Down

0 comments on commit 39048ae

Please sign in to comment.