Bug FORM IO (2.3) Fixes errors with offering submission missing information validations

[astridSABC]

Describe the Bug
Red warning fix the error or missing information messages displayed when they should not be. This includes when files are uploaded using the manual uploader (student), no study breaks (add offering), and change section with incomplete info (student)

• Request a Change
• Student File Uploader
• Application
• Institution Add Offering

Expected Behaviour

If valid information is included for an uploaded form or page, no red "Please fix the following errors before submitting" with links and highlights should be displayed

Change Request
Validation errors not being removed when submitting change request for an application.

Student File Uploader
File is uploaded with no red "Please fix the following errors" and the "Document Type" area is not highlighted in red

Student Family information tab: Yes/No to dependants
Change section with incomplete info is only for the page that needs to be updated

Institution Add offering
Toast message: "Offering was validated successfully and no warnings were displayed" is displayed. Institution user click "Add offering now"

Actual Behaviour

Student File Uploader
Warning are displayed even though the file is attached

Student Dependants Yes/No
Warning are also displayed on the financial information and confirm submission tabs. User must refresh the page for the warnings to be removed.

Family information tab

Financial information tab

Confirm submission tab

Institution: Add Offering

** Steps To Reproduce**

Student File Upload

Steps to reproduce the behaviour:

1. Login to the student portal
2. Click "File Uploader" in the top right of the page
3. Select any document type
4. Drag a file onto the "Drop files to attach" section
5. Click "Submit documents"
6. Note above the "Upload your documents" section
7. Note the "Document details" area

Student Dependants Yes/No

Steps to reproduce the behaviour:

1. Login to the student portal
2. Click "Start application"
3. Select "(2024 - 2025)..." for program year
4. Click "Start application"
5. Program tab: select valid information
6. Personal information tab:

• Select "I confirm"
• Select "Canadian Citizen"
• Select "Yes" for resident of BC
• Select "No" for identify as
• Select "No" for former youth and care
• Select "No" for disability
• Select "No" for trusted contact
• Click "Next section"

7. Family tab:

• Select "Single" for marital status
• Select "Yes"
• Click "Next section"
• Note the warnings on the screen
• Select "No"

8. Note the page
9. Click "Next section" to the Financial information tab
10. Note the page
11. Click "Next section" to the Confirm submission tab
12. Note the page

Institution User: "No study breaks selected" but red warning fix the error message displayed

Steps to reproduce the behaviour:

BC Public institution with a program that allows for PT, onsite

1. Login to the institution portal
2. Click "Locations"
3. Click "View" beside the program you want to add an offering to
4. Click "Add offering"
5. Make the page size large enough so you can see the "Unfunded Study Days" field as you enter study end date and remaining information
6. Add any valid date to "Name" field
7. Select any year
8. Select "Part time" for how will this be offered
9. Enter a course load amount (e.g. 40)
10. Select "Onsite"
11. Select "No" for WIL
12. Enter any valid study dates (e.g. November 4, 2024 - February 21, 2024)
13. Select "No" for Study breaks
14. Enter "$1000" for Tuition, Books and Supplies, and Mandatory Feed
15. Enter "0" for Exceptional Costs
16. Select "Yes" for offering is for all students
17. Select "I confirm"
18. Click "Validate"

Related issue: 4240

[CarlyCotton]

Calling this Asset - setting to release 2.5 but could consider as a last-minute 2.4 addition if space exists.