#4281 - SDPR API - Student search result - Student details

[dheepak-aot]

PR Scope

1. Student external search result - Student details from SIMS and SFAS
2. Update E2E Test token helper
3. E2E tests for external controller

Student search result - Student details

• Updated the existing external API to return Student details(Application details is hardcoded and will be implemented in upcoming PR) from SIMS and SFAS.
• Created StudentInformationService to get all student related information details based on both SIMS and SFAS.

E2E Test Helpers

• Updated the E2E test helpers with an option to provide client id and client secret to obtain the token.
• Created a helper method to get external token.
• Created a new Repository secret that will be used by E2E tests for external controller.

E2E Tests

• Created E2E tests for the external controller.

Upcoming PR

• Return FT application details in student search result.
• E2E tests for application data.

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

[github-actions]

Backend Unit Tests Coverage Report

Totals
Statements:	22.08% ( 3928 / 17791 )
Methods:	9.93% ( 226 / 2276 )
Lines:	25.44% ( 3394 / 13340 )
Branches:	14.16% ( 308 / 2175 )

[github-actions]

E2E Workflow Workers Coverage Report

Totals
Statements:	65.59% ( 589 / 898 )
Methods:	59.63% ( 65 / 109 )
Lines:	68.72% ( 468 / 681 )
Branches:	51.85% ( 56 / 108 )

[github-actions]

E2E Queue Consumers Coverage Report

Totals
Statements:	85.28% ( 1425 / 1671 )
Methods:	83.33% ( 160 / 192 )
Lines:	87.7% ( 1177 / 1342 )
Branches:	64.23% ( 88 / 137 )

[github-actions]

E2E SIMS API Coverage Report

Totals
Statements:	70.3% ( 6356 / 9041 )
Methods:	67.71% ( 782 / 1155 )
Lines:	73.94% ( 4955 / 6701 )
Branches:	52.24% ( 619 / 1185 )

[andrewsignori-aot]

Please import it from the index.

import { AddressAPIOutDTO } from "../..";

[andrewsignori-aot]

Is this a temporary solution or is it already the final approach to return student data?
I was assuming that the entire dataset of student + application data (a single query) would be executed (in parallel), targeting SIMS data and SFAS data. From the complete result of these two queries a "merge" would happen.
Is the idea that sfasIndividualPromise and studentPromise will be expanded?

[andrewsignori-aot]

For my understanding, will these transform methods be moved into some service to keep the controller "clean" in some upcoming PR?

[andrewsignori-aot]

Great work and thanks for enabling the secret auth for E2Es. Please take a look at the comments, mostly questions for clarification.